Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson Scanner Goggles #1264

Closed
wants to merge 15 commits into from
Closed

Conversation

WarMechanic
Copy link
Contributor

@WarMechanic WarMechanic commented Nov 22, 2024

Description

Engineering buff, and SS13 feature now in SS14.
Engineering Goggles, now 'Meson Scanner Goggles' get an active toggle that lets them visualise the station's structure through walls.

I basically did no work on this, and haven't done any PR work for like half a year so I'm very rusty. So I would like to see this reviewed first.


TODO

  • resurrect abandoned wizden pr
  • attach media (im watching poe2 streams)
  • change MesonsNonviewable component? or look for a better alternative that might be more maintainer friendly
  • stop halving my fps when i turn on mesons
  • make sure its good quality

Media

image


Changelog

🆑 notquitehadouken, WarMechanic

  • tweak: Meson Scanner Goggles (previously Engineering Goggles) can now see through walls.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an RSI Changes: Audio Changes any ogg files labels Nov 22, 2024
Copy link
Contributor

RSI Diff Bot; head commit ad38e31 merging into 8a88bfd
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Eyes/Glasses/meson.rsi

State Old New Status
icon Modified
enabled Added

@WarMechanic
Copy link
Contributor Author

depending on how the code works, i want to change from using MesonsNonviewable component to use the tag system instead? something like that

having to blacklist certain things seems pretty shit for maintainers

@WarMechanic
Copy link
Contributor Author

oh yeah also turning on the meson goggles halves my fps for some reason, i need to investigate that too

@WarMechanic
Copy link
Contributor Author

need to remove enable/disable visibility out of a frametime loop, and simply update whats visible when things are appended/dropped from a list

@FoxxoTrystan
Copy link
Member

I think best is to add a whitelist, not a blacklist.

@WarMechanic
Copy link
Contributor Author

I think best is to add a whitelist, not a blacklist.

yeah i thought so too, but if i make a whitelist ill have to hide everything not in the whitelist (which requires checks)
so here a blacklist might be technically preferable but ill need to ensure its not annoying for maintainers
would inheriting components from base mobs / items / whatever be fine?

@WarMechanic
Copy link
Contributor Author

i dont like mesons when they disable visibility of certain things you already see, and i dont know enough about shaders to have only walls/tiles appear in the place of darkness / los (this visualisation of mesons would be ideal)

i might revisit this in the future, but im going to be occupied with poe2 launch so gg

@WarMechanic WarMechanic closed this Dec 3, 2024
@FoxxoTrystan
Copy link
Member

I think best is to add a whitelist, not a blacklist.

yeah i thought so too, but if i make a whitelist ill have to hide everything not in the whitelist (which requires checks) so here a blacklist might be technically preferable but ill need to ensure its not annoying for maintainers would inheriting components from base mobs / items / whatever be fine?

Il prefer instead we use like CM14 uses for xeno to see resin, instead of hiding, we use the normal FOV, and just render things that we want to see, including walls, pehaps floors, ect...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants