Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lathe Naming Convention Fix #1272

Conversation

sleepyyapril
Copy link
Contributor

@sleepyyapril sleepyyapril commented Nov 24, 2024

Description

ERM HELLO??? BASED DEPARTMENT???

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Nov 24, 2024
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol.

@Remuchi
Copy link
Contributor

Remuchi commented Nov 29, 2024

I do want to rise a concern that this will introduce both breaking changes for downstreams AND future merge conflicts without actually doing anything useful, fixing bugs or anything else. To me it feels almost pointless, only bringing more problems than fixes. But that's just my opinion

@Mnemotechnician
Copy link
Contributor

Yeah, breaking downstreams with changes that do not improve anything is one of those things everyone hated about wizden.

@sleepyyapril
Copy link
Contributor Author

I do want to rise a concern that this will introduce both breaking changes for downstreams AND future merge conflicts without actually doing anything useful, fixing bugs or anything else. To me it feels almost pointless, only bringing more problems than fixes. But that's just my opinion

Agree, I'll likely close

@sleepyyapril sleepyyapril deleted the naming-conventions-lathe branch November 29, 2024 13:05
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants