Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Loadout Equipment #1281

Merged
merged 16 commits into from
Nov 30, 2024

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Nov 25, 2024

Description

This PR adds a bunch more equipment selections for Engineering loadouts, plus Suit/Skirt selections for the jobs that were missing it.

Media

image

Changelog

🆑

  • add: All engineering roles have had their equipment loadouts significantly expanded upon. Engineers can now buy construction materials with their loadout points.
  • fix: All engineering jobs now have their Suit/Skirt selection via loadouts.
  • add: Salvage techs can now select from a variety of knife options to start their spess adventures with.
  • add: Epistemics staff now have some equipment selection options that they share. More to come when I finish making the Potentiometer.

@github-actions github-actions bot added the Changes: YML Changes any yml files label Nov 25, 2024
@FoxxoTrystan
Copy link
Member

I am fully against this PR as this just bloat loadout, loadout are to customize your character looks not fully replace equipements, ect...

Lockers exist for a reason and getting materials in some parts, this just nullifies it.

@VMSolidus
Copy link
Member Author

I am fully against this PR as this just bloat loadout, loadout are to customize your character looks not fully replace equipements, ect...

Lockers exist for a reason and getting materials in some parts, this just nullifies it.

image

@VMSolidus VMSolidus changed the title Engineering Loadout Equipment More Loadout Equipment Nov 26, 2024
@rbertoche
Copy link
Contributor

If we want to go this way, it would be great to have default loadouts with a decent starting kit. Suppose a player who is late joining did not find their "main" slot available and then late join as atmos tech before realizing they should take a look at it's loadouts first, which is always going to be a common thing to happen. They will lack basic tools to even enter engineering and turn it on. Is this supposed to be happening? In a higher pop scenario it's fine, but in low pop it's more likely the only engineering staff available is said atmos tech, and not turning the power on time is also common in low pop.

Not to mention having starting kits made to be like a "blank slate" which you need to customize to get basic shit, you make the game harder for newcomers who have no idea what a loadout even is. If there were default loadouts I would probably re-add on our side some things which were moved from the starting kit to loadouts to it, such as survival kits.

@rbertoche
Copy link
Contributor

TLDR; Basic tools to get your job done would be better as an opt-out, not an opt-in.

@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Nov 29, 2024
@VMSolidus
Copy link
Member Author

I have given salvage players their own special attention. You're welcome.

image

@VMSolidus
Copy link
Member Author

Test fails are more or less unrelated to this PR.
Y'all clowns need to review this before I add 300 more items to it.

Copy link
Contributor

@sleepyyapril sleepyyapril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering these is YML and FTL changes and there's no linter screaming, this is fine.

Copy link
Contributor

@Remuchi Remuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine I guess?

@VMSolidus VMSolidus merged commit 0bd9a9e into Simple-Station:master Nov 30, 2024
10 of 11 checks passed
sleepyyapril pushed a commit to sleepyyapril/Einstein-Engines that referenced this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants