Skip to content

Conversation

@SimpleStation14
Copy link
Member

Mirror of PR #25881: Syringes that spawn with content start in inject mode from space-wizards space-wizards/space-station-14

5cb48c922fa7236d07b463f0c38ada2d5805e54b

PR opened by Plykiya at 2024-03-06 13:43:59 UTC
PR merged by web-flow at 2024-03-09 10:19:03 UTC


PR changed 3 files with 25 additions and 23 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

About the PR

Made it so that syringes that spawn with content start out in inject mode rather than draw mode. Also got rid of unnecessary DataField names if they matched.

Why / Balance

Grab bic syringe from medkit, use it on patient, it's in draw mode by default, cry.

Technical details

I added a new yml entity for prefilled syringes that starts in inject mode.

I attempted to do it the "smart way" by changing the ComponentInit code to check for the solution amount and toggle based on that, but for some reason the solution was returning false on the server-side but not on the client-side so there was a desync in the Inject state. Couldn't really figure out how to fix it, so I just went with the dumb simple method instead.

Media

  • [ X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None

Changelog

🆑

  • tweak: Pre-filled syringes start in inject mode now.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 6, 2024 17:29
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label May 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@DangerRevolution DangerRevolution requested review from a team and VMSolidus May 13, 2024 13:46
@github-actions github-actions bot added the Status: Needs Review Someone please review this label May 13, 2024
@DangerRevolution DangerRevolution added Changes: C# Changes any cs files Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Awaiting Changes Do not merge due to requested changes Type: Feature Creation of or significant changes to a feature labels May 13, 2024
@github-actions github-actions bot added Changes: YML Changes any yml files and removed Status: Merge Conflict FIX YOUR PR AAAGH labels May 29, 2024
@VMSolidus VMSolidus merged commit 2bbf7ad into Simple-Station:master May 29, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 4-Small For small issues/PRs Status: Awaiting Changes Do not merge due to requested changes Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants