Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lobotomy #1306

Merged
merged 8 commits into from
Dec 3, 2024
Merged

Fix Lobotomy #1306

merged 8 commits into from
Dec 3, 2024

Conversation

angelofallars
Copy link
Contributor

Description

Fixes several bugs in the lobotomy procedure.

The lobotomy effect is now stored in the brain instead of the body, so transferring a lobotomized brain will still give the lobotomy effects, and a brain transplant to a body where a lobotomy occurred no longer applies the lobotomy effects. The "Mend brain tissue" procedure to reverse a lobotomy has been unlocked after a bug prevented it from showing in the surgery UI.

Lobotomies now add the ClumsyComponent, which makes the lobotomized target as clumsy as clowns.

Technical Details

This deletes SurgeryComponentConditionComponent.cs which was only used for the lobotomy procedures (incorrectly, it was checking for OhioAccentComponent in the body part) in favor of SurgeryPartComponentConditionComponent.cs and SurgeryBodyComponentConditionComponent.cs.

These two components are currently unused as the lobotomy procedures use a new condition component checking for the brain's OrganComponent.OnAdd field, but they provide a way to check for components on the body part and on the body, respectively.

Media

Lobotomy
image

Mend brain tissue
image

Remove organ step picture

image

Changelog

🆑 Skubman

  • add: The lobotomy procedure makes the target clumsy like the clown. This makes them bonk when climbing tables and makes guns they're shooting blow up on their face.
  • tweak: The lobotomy step now requires a scalpel instead of a drill.
  • fix: Enabled the "Mend brain tissue" surgical procedure on a lobotomized target.
  • fix: The lobotomized effect is now stored in the brain instead of the body. The same brain stays lobotomized throughout brain transplants, and transferring a normal brain to a body where a lobotomy occurred no longer applies the lobotomized effect.
  • fix: The lobotomy procedure now shows the proper popup during the lobotomization step.
  • fix: Removed the ability to perform lobotomies on bodies without a brain.
  • fix: The "Remove organ" surgery step on the UI now properly shows the retractor sprite instead of the hemostat.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Dec 2, 2024
@sleepyyapril
Copy link
Contributor

I'll accept this when you try to murder the curlies as best you can.

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Dec 3, 2024
@angelofallars
Copy link
Contributor Author

Tried to murder the curlies as best as I can, but some of them might still be alive though.

@VMSolidus VMSolidus merged commit 1895f3a into Simple-Station:master Dec 3, 2024
10 of 11 checks passed
VMSolidus pushed a commit to Ichaie/Einstein-Engines that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants