CVar CharacterRequirement #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
Signed-off-by: sleepyyapril <[email protected]>
Signed-off-by: sleepyyapril <[email protected]>
…ngines into cvar-requirement
…but still needs to inherit as such.
…nstein-Engines into cvar-requirement
FoxxoTrystan
reviewed
Dec 9, 2024
Content.Shared/Customization/Systems/CharacterRequirements.Misc.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: sleepyyapril <[email protected]>
VMSolidus
requested changes
Dec 9, 2024
Content.Shared/Customization/Systems/CharacterRequirements.Misc.cs
Outdated
Show resolved
Hide resolved
…c.cs Co-authored-by: VMSolidus <[email protected]> Signed-off-by: sleepyyapril <[email protected]>
VMSolidus
approved these changes
Dec 9, 2024
DEATHB4DEFEAT
approved these changes
Dec 9, 2024
Resources/Locale/en-US/customization/character-requirements.ftl
Outdated
Show resolved
Hide resolved
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: sleepyyapril <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This takes in one CVar and one required value and simply checks if the CVar's value as a string is equal to the required value. I could make it use a list of them, but I really didn't think it was needed considering CharacterAndLogic.
I also cleaned up CharacterRequirements.Profile.cs a bit.