Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port] Add Time Transfer Panel From Goobstation #1429

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

CerberusWolfie
Copy link
Contributor

@CerberusWolfie CerberusWolfie commented Jan 5, 2025

Description

This adds the Time Transfer Panel that Goobstation uses. This panel enables Admins to do Time Transfers without commands and makes their lives easier. This immediately has access to all playtime trackers and allows an Admin to Add Time and/or Set Time (overwriting the previous time) for any job role. It also enables extra strings since I ported from Wizden upstream as well, which can be seen in the commit history.

A thing of note when testing this and using it in a server: the times DO NOT UPDATE for Client until your RELOG. This is how it works on Goobstation as well. The time adding process is faster and will be easier tool.

This is tied to the AdminFlags.Admin so it can be customized on a per-server basis if a custom flag is added.


TODO

  • Port Upstream Role Define.
  • Port string extras for playtime commands.
  • Port Time Transfer Panel
  • Remove Overall (it just doesn't work on Goob either).

Media

image
image
image
image
image
image
image
image
image


Changelog

🆑
ADMIN:

  • add: Add Time Transfer Panel

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files labels Jan 5, 2025
@SimpleStation14 SimpleStation14 changed the title Time transfer upstream Time Transfer Upstream Jan 5, 2025
@CerberusWolfie CerberusWolfie changed the title Time Transfer Upstream [Port] Add Time Transfer Panel from Goobstation Jan 5, 2025
@SimpleStation14 SimpleStation14 changed the title [Port] Add Time Transfer Panel from Goobstation [Port] Add Time Transfer Panel From Goobstation Jan 5, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Jan 7, 2025
@CerberusWolfie
Copy link
Contributor Author

There. I force-pushed upstream merge into my branch so it stops bitching about merge conflicts.

@Remuchi Remuchi merged commit a05bbce into Simple-Station:master Jan 7, 2025
10 of 11 checks passed
SimpleStation14 added a commit that referenced this pull request Jan 7, 2025
@CerberusWolfie CerberusWolfie deleted the TimeTransferUpstream branch January 8, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants