Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Non-Verbal Langs Not Play Speech #1448

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

RadsammyT
Copy link
Contributor

Description

Makes non-verbal languages no longer emit speech sounds. Ported from Goob-Station-MRP#29 at @angelofallars's request.


Media

PR Example


Changelog

🆑

  • tweak: Languages that don't require speech (I.E. Sign Language) will no longer play speech sounds.

angelofallars and others added 3 commits January 5, 2025 15:46
# Description

**(Use a MERGE COMMIT, not squash if possible to ~~avoid~~ reduce merge
conflicts for our downstream)**

Cherry-picks some PRs from The Den:

- TheDenSS14/TheDen#8
- TheDenSS14/TheDen#31
- TheDenSS14/TheDen#108
- TheDenSS14/TheDen#116
- TheDenSS14/TheDen#117
- TheDenSS14/TheDen#123
- TheDenSS14/TheDen#124

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: The Den Contributors
- fix: Put actual prescription lenses in the prescription medhuds and
sechuds (by KyuPolaris)
- add: Added the CMO turtleneck and head mirror to the CMO loadouts. (by
sleepyyapril, KyuPolaris)
- add: Added an armored trenchcoat for the Captain. Enjoy your swag! (by
Rosycup)
- fix: Fixed uneven pants leg on summer security uniforms. (by Rosycup)
- add: Added the Captain's Combat Gas Mask, for those more fond of close
encounters. (by Rosycup)
- tweak: Added the Captain's Trenchcoat to the other captain locker
variants. (by Rosycup)
- fix: Fixed they/them pronouns being displayed for it/its characters in
the character preview. (by Azzy)

---------

Co-authored-by: flyingkarii <[email protected]>
Co-authored-by: sleepyyapril <[email protected]>
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jan 6, 2025
@SimpleStation14 SimpleStation14 changed the title Make non-verbal langs not play speech Make Non-Verbal Langs Not Play Speech Jan 6, 2025
@angelofallars
Copy link
Contributor

Excellent.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@RadsammyT
Copy link
Contributor Author

bruh.

@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Jan 7, 2025
@Remuchi Remuchi merged commit 990a57c into Simple-Station:master Jan 7, 2025
10 of 11 checks passed
SimpleStation14 added a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants