Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddTraitSpecial #1528

Merged
merged 2 commits into from
Jan 13, 2025
Merged

AddTraitSpecial #1528

merged 2 commits into from
Jan 13, 2025

Conversation

Peptide90
Copy link
Contributor

Adds a way to specify traits in the jobs special area.

Hashset so you can specify multiple traits. Tested on Nuclear14 to give the tribals a specific language in a friendly way.

  special:
  - !type:AddTraitSpecial
    traits: [ LanguageTribal, LanguageChinese ]

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jan 13, 2025
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I so desperately wished EntProtoId actually worked in these, we otherwise could have skipped the need to index them in the first place. Otherwise yep, this is good here. I think you may be crazy here for using a hash set(Uniqueness, oddly enough, isn't actually required for traits). But fussing over which array type is best is an insane thing to ask for a function that isn't going to be iterating through tens of thousands at a time.

@VMSolidus VMSolidus merged commit bc0708a into Simple-Station:master Jan 13, 2025
11 of 12 checks passed
@Peptide90 Peptide90 deleted the addtraitspecial branch January 13, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants