Ports Fixes to some Looping Systems, LightBehaviorSystem Refactor From Wizden #1552
+157
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
SimpleStation14
changed the title
…ngines into ee_lighting_fix
VMSolidus
requested changes
Jan 15, 2025
Co-authored-by: VMSolidus <[email protected]> Signed-off-by: spess-empyrean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports over these commits from Wizden:
space-wizards/space-station-14@32e315c
space-wizards/space-station-14@8d015f5
Namely the first is a general refactor to LightBehaviorSystem and the second is a bugfix that fixes some looping behaviors like the low battery effect on a flashlight never stopping. If it's not atomic enough, let me know and I can separate them into two.
Changelog
🆑