Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Immovable Rod visual variations #371

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25932: Immovable Rod visual variations from space-wizards space-wizards/space-station-14

8f652eaa7560a47a750173d716426dcd1ad7c01b

PR opened by SlamBamActionman at 2024-03-08 15:02:40 UTC


PR changed 4 files with 122 additions and 6 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

About the PR

This PR adds 7 rare visual variations to the Immovable Rod, making it possible for other wacky items to replace the basic metal rod.

The current items have been added:

  • Mop
  • Hammer
  • Shark (Plushie)
  • Banana
  • Clown
  • Throngler
  • Gibstick

Why / Balance

Gives the immovable rod some more flavor and fits the announcement warning text, which is non-specific as of what item hits the station. The variations will not change the effect of the immovable rod.

To keep the variations rare and interesting when they happen, the rod has only a 1 in 10 chance to be replaced by a variation. All variations have an equal chance to be chosen.

Technical details

Uses a similar pick system to the Wilhelm scream easter egg, though with prototypes instead of sound files.

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

no cl lots of fun

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label May 3, 2024
@VMSolidus VMSolidus marked this pull request as ready for review May 12, 2024 03:11
@VMSolidus
Copy link
Member

Oh god NO.

@VMSolidus VMSolidus closed this May 12, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants