Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Make parrots talk like parrots #381

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26340: Make parrots talk like parrots from space-wizards space-wizards/space-station-14

cd4eda44b88a75d7498efca42c464dd4c73c5684

PR opened by Tayrtahn at 2024-03-22 17:22:18 UTC


PR changed 8 files with 168 additions and 0 deletions.

The PR had the following labels:


Original Body

About the PR

In the rare cases that parrot become controlled by players, they now sound a bit more parrot-y.

  • Added the parrot squawk sound as a speech sound, so they no longer speak silently.
  • Gave parrots a speech verb set, so they "squawk", "tweet", and "chirp" their messages, instead of just "say"-ing them.
  • Parrots can "scream" now (which just plays the squawk sound).
  • Parrots have their own accent that gets applied to everything they say! It adds some random squawks to the beginnings and ends of messages. Sometimes they repeat the longest word in a message. RAAWK! Sometimes!

Why / Balance

There are a lot of animals, but very little that sets them apart from each other. This makes parrots a little more interesting (though there's plenty more to be done).

And no, I've never seen a player-controlled parrot in the game either. But it could happen! And when it does, now it'll be cooler.

Technical details

Added a few components to the parrot entity prototype, and made EmoteSounds, SpeechSounds, and SpeechVerb for parrots.

Added ParrotAccentComponent/System, which handle the accent.

Media

Screen.Recording.2024-03-22.at.12.40.13.PM.mp4

Sorry for the lack of audio; blame Apple. There are squawking noises whenever the parrot chats or screams.

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Parrots now sound more like parrots when they talk. RAWWK!

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label May 3, 2024
@VMSolidus VMSolidus marked this pull request as ready for review May 10, 2024 02:37
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

But i wounder how exactly its will function with Languages, Meaning i have to make a Parrot/Bird Language and make it able to speak GC?

Thats a problem for Language PR, not this PR but so far This PR is good!

@DangerRevolution
Copy link
Contributor

This is good.

But i wounder how exactly its will function with Languages, Meaning i have to make a Parrot/Bird Language and make it able to speak GC?

Not necessary, up to you really, the System of Languages is the important part, the actual yml languages can be done after the fact. Up to you really though.

@FoxxoTrystan
Copy link
Contributor

This is good.
But i wounder how exactly its will function with Languages, Meaning i have to make a Parrot/Bird Language and make it able to speak GC?

Not necessary, up to you really, the System of Languages is the important part, the actual yml languages can be done after the fact. Up to you really though.

This can be handle easly later.
and is a issue for Languages PR, when this PR is merged i will make a new commit on Language to correctly handle this PR.

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an accent system, is fine.

@VMSolidus VMSolidus merged commit 7548a3f into Simple-Station:master May 12, 2024
20 checks passed
VMSolidus pushed a commit to VMSolidus/Einstein-Engines that referenced this pull request Aug 16, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants