Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: Code cleanup: Purge obsoleted SharedPhysicsSystem methods #384

Merged
merged 1 commit into from
May 20, 2024
Merged

Mirror: Code cleanup: Purge obsoleted SharedPhysicsSystem methods #384

merged 1 commit into from
May 20, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26287: Code cleanup: Purge obsoleted SharedPhysicsSystem methods from space-wizards space-wizards/space-station-14

964c6d54caae45b205a326143f56d6458a1bbc8a

PR opened by Tayrtahn at 2024-03-20 13:37:25 UTC

PR changed 16 files with 43 additions and 43 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

Requires space-wizards/RobustToolbox#4979

About the PR

Cleans up some obsolete method calls.

Why / Balance / Technical

Cleaning up obsolete Dirty calls in RT required changing the signatures of some public methods in SharedPhysicsSystem. This updates the calls to those methods here in Content to use the new signatures passing in UIDs.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label May 3, 2024
@VMSolidus VMSolidus marked this pull request as ready for review May 12, 2024 04:47
VMSolidus
VMSolidus approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to merge conflict my space wind rework lmao, but I'm fine with that because it'll be trivial.

DangerRevolution
DangerRevolution approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting VM on this

@DangerRevolution DangerRevolution merged commit 156dfb6 into Simple-Station:master May 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DangerRevolution DangerRevolution DangerRevolution approved these changes

@VMSolidus VMSolidus VMSolidus approved these changes

Assignees
No one assigned
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimpleStation14 @VMSolidus @DangerRevolution