Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: Wearable Harmonicas #386

Merged
merged 1 commit into from
May 3, 2024
Merged

Mirror: Wearable Harmonicas #386

merged 1 commit into from
May 3, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26261: Wearable Harmonicas from space-wizards space-wizards/space-station-14

b60f61c7b79cebf07743c057e4a89202ca06f258

PR opened by ImWeax at 2024-03-19 14:18:13 UTC

PR changed 1 files with 7 additions and 1 deletions.

The PR had the following labels:

  • No C#
  • Status: Needs Review

Original Body

About the PR

Made harmonicas wearable (and playable) in the neck slot.

Why / Balance

Sprite has a neck loop and it was bugging me you couldn't wear them

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 Weax

  • tweak: Harmonicas can now be equipped (and played) in the neck slot.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label May 3, 2024
Pspritechologist
Pspritechologist approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@Pspritechologist Pspritechologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fucking good

@Pspritechologist
Copy link
Member

It does mean you can play a harmonica in your pocket but
Maybe you're just skilled like that

@VMSolidus VMSolidus marked this pull request as ready for review May 3, 2024 17:41
VMSolidus
VMSolidus approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow it runs the tests on these new ones when I mark it as not draft. That's very nice. :)

@VMSolidus VMSolidus merged commit 69408b1 into Simple-Station:master May 3, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
@FoxxoTrystan
Merge pull request Simple-Station#386 from JasmineRickards/ert
e4a891d 
NTNF Ship Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pspritechologist Pspritechologist Pspritechologist approved these changes

@VMSolidus VMSolidus VMSolidus approved these changes

Assignees
No one assigned
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimpleStation14 @Pspritechologist @VMSolidus