Skip to content

Conversation

@dwhoban
Copy link
Contributor

@dwhoban dwhoban commented Sep 21, 2025

This pull request makes several improvements to the rclone mount systemd service template and rclone configuration template. The changes focus on log management, mount options, service reliability, and configuration consistency.

Service template improvements:

  • Added --log-file-max-size 5M to limit the size of rclone log files, helping to prevent disk space issues.
  • Added --vfs-links to the mount options to enable support for symbolic links in the mounted remote.
  • Changed the service restart policy from Restart=on-abort to Restart=on-failure for improved reliability in case of errors.

Configuration template update:

  • Changed idle_timeout from 0s to 0 for improved consistency and compatibility in the rclone configuration.

Copilot AI review requested due to automatic review settings September 21, 2025 06:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the rclone mount systemd service and configuration templates to address timeout issues and enhance service reliability. The changes focus on log file management, mount options for symbolic links, service restart behavior, and configuration consistency.

  • Added log file size limiting and symbolic link support to the mount service
  • Changed service restart policy from on-abort to on-failure for better error handling
  • Updated configuration template to use numeric timeout value instead of string format

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
includes/rclone/rclone-template.conf Updated idle_timeout from "0s" to "0" for consistency
includes/rclone/rclone-mount-template.service Added log size limit, symbolic link support, and improved restart policy

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant