-
Notifications
You must be signed in to change notification settings - Fork 48
Set register command #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…plays on top of this library
|
Hi @Simsso, Thank you for maintaining this great library—it's been incredibly useful in my projects. I noticed this pull request and wanted to say that the I believe it aligns well with the library's design principles and could benefit its users. If there's anything I can do to help with testing, documentation, or further reviewing this PR, I'd be happy to assist. Looking forward to your thoughts on this. |
| } | ||
|
|
||
| // Set all pins of a single shift registers at once. | ||
| // digitalVAlues is a uint8_t, reg is a uint8_t from 0 to Size -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // digitalVAlues is a uint8_t, reg is a uint8_t from 0 to Size -1 | |
| // digitalValues is a uint8_t, reg is a uint8_t from 0 to Size -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Simsso Can you apply this patch before merging to fix the case?
|
Thanks, @jasonwbarnett. Did you have a chance to test the new function? If so, I'd be happy to submit the PR. We only need to increment the minor library version. |
|
Hi! I wanted to gently nudge and see if there is anything I need to do to get this merged. Thanks for your time. |
I've added the ability to set a single register. I needed an extremely simple 595 7-segment library and this mostly fits the bill, thanks.