Fix profiles erroring when the player never played

Fixes #21
Simyon264 · Aug 24, 2024 · f17c4ff · f17c4ff
1 parent 92f2e99
commit f17c4ff
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 13 deletions.
diff --git a/ReplayBrowser/Helpers/ReplayHelper.cs b/ReplayBrowser/Helpers/ReplayHelper.cs
@@ -105,7 +105,7 @@ public async Task<CollectedPlayerData> GetPlayerProfile(Guid playerGuid, Authent
             });
         }
 
-       var replayPlayers = await _context.Players
+        var replayPlayers = await _context.Players
             .AsNoTracking()
             .Where(p => p.Participant.PlayerGuid == playerGuid)
             .Where(p => p.Participant.Replay!.Date != null)
@@ -121,6 +121,27 @@ public async Task<CollectedPlayerData> GetPlayerProfile(Guid playerGuid, Authent
             })
             .ToListAsync();
 
+        if (replayPlayers.Count == 0)
+        {
+            return new CollectedPlayerData()
+            {
+                PlayerData = new PlayerData()
+                {
+                    PlayerGuid = playerGuid,
+                    Username = (await _apiHelper.FetchPlayerDataFromGuid(playerGuid)).Username ??
+                               "Unable to fetch username (API error)"
+                },
+                PlayerGuid = playerGuid,
+                Characters = new List<CharacterData>(),
+                TotalEstimatedPlaytime = TimeSpan.Zero,
+                TotalRoundsPlayed = 0,
+                TotalAntagRoundsPlayed = 0,
+                LastSeen = DateTime.MinValue,
+                JobCount = new List<JobCountData>(),
+                GeneratedAt = DateTime.UtcNow
+            };
+        }
+
         var replayPlayerGroup = replayPlayers.GroupBy(rp => rp.ReplayId);
 
         var totalRoundsPlayed = replayPlayerGroup.Count();

diff --git a/ReplayBrowser/Pages/Profile.razor b/ReplayBrowser/Pages/Profile.razor
@@ -23,11 +23,6 @@ else if (IsPrivate)
     <h1>Protected data (@Username)</h1>
     <p>@(Exception?.Message ?? "No info")</p>
 }
-else if (FailedToLoad)
-{
-    <h1>Error (@Username)</h1>
-    <p>Failed to load player data. Exception: @(Exception?.Message ?? "No info")</p>
-}
 else
 {
     <MetaDataSpecifer
@@ -197,12 +192,5 @@ else
             Exception = e;
             _playerData = new();
         }
-        catch (Exception e)
-        {
-            FailedToLoad = true;
-            Exception = e;
-            _playerData = new();
-            Log.Error(e, "Failed to load player data.");
-        }
     }
 }