Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for configuration channels in NetworkRegistryMixin#preserveSendableChannels #171

Open
wants to merge 1 commit into
base: 1.21.1
Choose a base branch
from

Conversation

unilock
Copy link
Contributor

@unilock unilock commented Nov 21, 2024

Fixes client disconnecting from dedicated server with Fabric mods that register configuration phase packets (such as Spell Engine)

…ndableChannels

Fixes client disconnecting from dedicated server with Fabric mods that register configuration phase packets

Signed-off-by: unilock <[email protected]>
@Tapacywka
Copy link

This PR doesn't help solve the issue
image

@unilock
Copy link
Contributor Author

unilock commented Nov 24, 2024

@Tapacywka That's the issue this PR is supposed to fix, and it did appear to fix it for me... I'm not sure what the issue could still be. Hopefully someone who's more knowledgeable about payload registration can shed some insight.

@Su5eD Su5eD added bug Something isn't working question Further information is requested labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants