Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previewDocs on Linux when using IntelliJ #5

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

cassiancc
Copy link
Contributor

Currently, when previewDocs is run through IntelliJ on Linux, it does not inherit custom paths from .bashrc. This becomes important when dealing with Node, which when installed through its nvm installer is not installed on the default path. This patch, based off this article, makes bash interactive, and fixes the path issues.

I've intentionally opted to leave macOS alone, as I'm not aware enough of how its version of bash differs to know if this patch is required.

I'm hoping this also fixes #2, but I've switched to a .deb version of IntelliJ at this point and haven't tested it.

@Jab125
Copy link
Contributor

Jab125 commented Feb 6, 2025

macOS was already fixed with #1, so be careful to not break macOS support again

@cassiancc
Copy link
Contributor Author

Yep, I've intentionally left the macOS commands the same as #1. I don't believe that running the new Linux ones would cause an issue, but as I'm unable to test macOS, I don't know that for sure.

@Su5eD Su5eD merged commit f0ed076 into Sinytra:master Feb 10, 2025
1 check passed
@cassiancc cassiancc deleted the fix-linux branch February 10, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

previewDocs fails when run via IntelliJ flatpak.
3 participants