Add review, query commands and pre-recorded answers support#362
Draft
rcj-siteimprove wants to merge 21 commits into
Draft
Add review, query commands and pre-recorded answers support#362rcj-siteimprove wants to merge 21 commits into
rcj-siteimprove wants to merge 21 commits into
Conversation
Enables commands that accept both positional arguments and subcommands — neither withSubcommands nor withArguments alone supports this combination.
Page serialized at High verbosity so every node carries internalId.
Outcomes serialized at Minimal verbosity as {type, internalId} stubs
— consumers resolve nodes by looking up internalId in the page,
avoiding duplicate node data across every outcome.
Adds `alfa interview` for recording oracle Q&A sessions and `alfa query` for inspecting audit results. The audit command gains an `--alfa-dir` flag to load pre-recorded answers so questions are resolved automatically on subsequent runs. Includes a Claude Code skill definition for the full interview → audit → query workflow.
🦋 Changeset detectedLatest commit: 52291f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import type { Oracle } from "@siteimprove/alfa-act"; | ||
| import type { Document } from "@siteimprove/alfa-dom"; | ||
| import { Future } from "@siteimprove/alfa-future"; | ||
| import { None, Option } from "@siteimprove/alfa-option"; |
rcj-siteimprove
changed the title
Co-locates the skill with the CLI source so renames like interview → review stay in sync in the same diff. Also fixes stale `alfa interview` references left over from 1a488e3, and adds a README with install instructions.
R98/R101 not yet published; aligns with how audit/run.ts handles it.
Contributor
Author
|
!pr extract |
All path helpers replaced with eager module-level constants. The --alfa-dir flag is removed from all commands; .alfa/ relative to CWD is now hardcoded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alfa reviewcommand for recording oracle Q&A sessions (answer, list, reset, status subcommands)alfa querycommand for inspecting and filtering audit result filesalfa auditwith--alfa-dirflag to auto-load pre-recorded answers, so oracle questions are resolved automatically on subsequent runsskills/alfa/SKILL.md) documenting the full review → audit → query workflowNotes
The audit command currently uses the standard ruleset. Experimental rules (R98, R101) are commented out pending publication of the local
alfapackages.Test plan
alfa review <url>lists unanswered questionsalfa review answer <hash=value>...records answers and surfaces follow-up questionsalfa review resetclears the sessionalfa review statusshows answered/unanswered countsalfa audit <url>picks up pre-recorded answers from--alfa-diralfa query <file>filters and inspects audit results