-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security Considerations #67
Conversation
Such measures can be: | ||
- Authentication, for example by using HMAC. See [Securing Processing Commands in ImageSharp.Web](../imagesharp.web/processingcommands.md#securing-processing-commands). | ||
- Offloading to separate services/containers. | ||
- Placing the solution behind a reverse proxy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this one given that you already mentioned offloading to a separate service. Would using a reverse proxy just be a way to implement the former?
Great list otherwise 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the offloading point I meant isolation of the image processing component, making sure that if it falls it doesn't bring the rest of the system with it.
Here I rather meant utlizing stuff like DDoS protection in cloudflare, but I must admit that I have no idea how that stuff works :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I don't think cloudflare would really help in this particular case, but it's not a bad recommendation in general
Co-authored-by: Miha Zupan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. If we need to make additional changes, we can follow up.
No description provided.