Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Considerations #67

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Security Considerations #67

merged 3 commits into from
Apr 15, 2024

Conversation

antonfirsov
Copy link
Member

No description provided.

Such measures can be:
- Authentication, for example by using HMAC. See [Securing Processing Commands in ImageSharp.Web](../imagesharp.web/processingcommands.md#securing-processing-commands).
- Offloading to separate services/containers.
- Placing the solution behind a reverse proxy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this one given that you already mentioned offloading to a separate service. Would using a reverse proxy just be a way to implement the former?

Great list otherwise 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the offloading point I meant isolation of the image processing component, making sure that if it falls it doesn't bring the rest of the system with it.

Here I rather meant utlizing stuff like DDoS protection in cloudflare, but I must admit that I have no idea how that stuff works :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I don't think cloudflare would really help in this particular case, but it's not a bad recommendation in general

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. If we need to make additional changes, we can follow up.

@JimBobSquarePants JimBobSquarePants merged commit db74567 into main Apr 15, 2024
3 checks passed
@JimBobSquarePants JimBobSquarePants deleted the af/security branch April 15, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants