Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on bitcoin#29346 and bitcoin#30315
TODO: expose
libbitcoinsv2
as C header API for use in external applicationsThis can probably borrow from bitcoin#30595
The goal is that you can do something like:
And then end up with just a
libbitcoinsv2
library for use in some other project. Specific projects I have in mind:Transport
subclass, its (proposed) c++ implementation of Noise, etc.