Check that mainnet test doesn't call the internet

[Sjors]

This tests the combination of bitcoin#31583 and bitcoin#31349.

[Sjors]

[12:31:33.726] 100% tests passed, 0 tests failed out of 138
[12:31:33.726] 
[12:31:33.726] Total Test time (real) = 384.95 sec
[12:31:33.738] + traffic_monitor_end unitparallel
[12:31:33.738] + test_name=unitparallel
[12:31:33.740] ++ get_interfaces
[12:31:33.740] ++ set -o pipefail
[12:31:33.741] ++ ifconfig
[12:31:33.742] ++ awk -F ':| ' '/^[^[:space:]]/ { if (!match($1, /^lo/)) { print $1 } }'
[12:31:33.763] ++ set +o pipefail
[12:31:33.765] + for ifname in $(get_interfaces)
[12:31:33.766] ++ tcpdump_file unitparallel eth0
[12:31:33.767] ++ echo /tmp/tcpdump_unitparallel_eth0
[12:31:33.769] + f=/tmp/tcpdump_unitparallel_eth0
[12:31:33.769] + '[' '!' -e /tmp/tcpdump_unitparallel_eth0 ']'
[12:31:33.769] + '[' '' = 1 ']'
[12:31:33.769] + chown root:root /tmp/tcpdump_unitparallel_eth0
[12:31:33.786] chown: /tmp/tcpdump_unitparallel_eth0: No such file or directory

cc @vasild
https://cirrus-ci.com/task/6013424313827328?logs=ci#L4616

The ARM test runs in qemu on my x86_64 machine, perhaps that's related?

[Sjors]

I pushed a rebased version of bitcoin#31583 to account for the merged tests in bitcoin#31646.

[vasild]

Before the tests:

[12:25:08.705] + tcpdump -nU -i eth0 -w /tmp/tcpdump_unitparallel_eth0
[12:25:08.722] tcpdump: eth0: SIOCETHTOOL(ETHTOOL_GET_TS_INFO) ioctl failed: Inappropriate ioctl for device

and that VM is not flagged as CI_TCPDUMP_OK_TO_FAIL, thus the failure. I guess ci/test/00_setup_env_arm.sh warrants this patch:

--- i/ci/test/00_setup_env_arm.sh
+++ w/ci/test/00_setup_env_arm.sh
@@ -15,6 +15,8 @@ export USE_BUSY_BOX=true
 export RUN_UNIT_TESTS=true
 export RUN_FUNCTIONAL_TESTS=false
 export GOAL="install"
 # -Wno-psabi is to disable ABI warnings: "note: parameter passing for argument of type ... changed in GCC 7.1"
 # This could be removed once the ABI change warning does not show up by default
 export BITCOIN_CONFIG="-DREDUCE_EXPORTS=ON -DCMAKE_CXX_FLAGS='-Wno-psabi -Wno-error=maybe-uninitialized'"
+# Can't run tcpdump: tcpdump: eth0: SIOCETHTOOL(ETHTOOL_GET_TS_INFO) ioctl failed: Inappropriate ioctl for device
+export CI_TCPDUMP_OK_TO_FAIL=1

but only in this environment (qemu), not on master which runs on Cirrus... hmm...

[Sjors]

I'll try setting CI_TCPDUMP_OK_TO_FAIL=1 as an env variable on my CI and run again. It should be enough to have instruction for that in the .cirrus.yml, where it suggests using qemu.

https://cirrus-ci.com/task/6101745434099712

Update: that worked.