Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies for Rails 7.1 #59

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Conversation

justisb
Copy link
Contributor

@justisb justisb commented Oct 19, 2023

Bumps activemodel and activesupport dependency ranges to allow Rails 7.1, which was released two weeks ago.

@justisb justisb marked this pull request as draft October 20, 2023 02:10
@justisb
Copy link
Contributor Author

justisb commented Oct 20, 2023

Looks like currently the RSpec suite is broken because Rails introduced their own Object#with monkey patch that interferes with the RSpec expect(x).to receive(:foo).with('bar') tests.

Waiting to see if there ends up being a resolution here: rspec/rspec-rails#2699

@justisb justisb marked this pull request as ready for review October 20, 2023 02:46
@justisb
Copy link
Contributor Author

justisb commented Oct 20, 2023

Actually just upgrading RSpec (or specifically the rspec-mocks child dependency) appears to have solved it.

@thhermansen
Copy link
Member

Thank you :)

@thhermansen thhermansen merged commit 041e46f into Skalar:main Oct 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants