ci: Fix libssl install for cross-compile #509
clippy
4 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 4 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.73.0 (cc66ad468 2023-10-03)
- cargo 1.73.0 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (cc66ad4 2023-10-03)
Annotations
Check warning on line 55 in src/disk.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> src/disk.rs:55:53
|
55 | let target = pathdiff::diff_paths(&destination, &source.parent().unwrap()).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `source.parent().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 55 in src/disk.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> src/disk.rs:55:39
|
55 | let target = pathdiff::diff_paths(&destination, &source.parent().unwrap()).unwrap();
| ^^^^^^^^^^^^ help: change this to: `destination`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 47 in src/disk.rs
github-actions / clippy
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/disk.rs:42:9
|
42 | / match fs::create_dir_all(parent) {
43 | | Err(err) => {
44 | | error!("Couldn't create folder {}: {}", parent.display(), err);
45 | | }
46 | | Ok(()) => (),
47 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
42 ~ if let Err(err) = fs::create_dir_all(parent) {
43 + error!("Couldn't create folder {}: {}", parent.display(), err);
44 + }
|
Check warning on line 120 in src/downloader.rs
github-actions / clippy
unnecessary hashes around raw string literal
warning: unnecessary hashes around raw string literal
--> src/downloader.rs:120:36
|
120 | Regex::new(r#"^.*(\b[a-z]+/[a-z-+\.]+).*$"#).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `r"^.*(\b[a-z]+/[a-z-+\.]+).*$"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
= note: `#[warn(clippy::needless_raw_string_hashes)]` on by default