run from repo (not gem)

[MSP-Greg]

From plugin directory:

rubocop -f extension_review -c<path to repo>/rubocop-sketchup/.rubocop.yml

[thomthom]

Can you fill in some background to these changes?

[MSP-Greg]

I forked the repo, and tried to run it. Didn't work. With PR, I believe it does.

I can run the tests with whatever version of Ruby, don't need to install the gem...

[thomthom]

Ah I see. I also see that rubocop itself also use relative paths. I'll make a note of that.

[thomthom]

Hmm.. how is rubocop able to use rubocop-sketchup if it's not installed as a gem using that command line: rubocop -f extension_review -c<path to repo>/rubocop-sketchup/.rubocop.yml

Is it the require: rubocop-sketchup line within the YAML that makes rubocop require it relative to the YAML file?

Also, it appear strange to use rubocop-sketchup/.rubocop.yml as a config - as that is set up for rubocop-sketchup itself, not reviewing extensions. It even disables the custom cops.

[MSP-Greg]

@thomthom

I haven't pushed to this branch, but locally rebasing on PR #156, it does run correctly. I don't recall if I made additional changes, but running the following did work (RuboCop installed as a gem):

rubocop -f RuboCop::Formatter::ExtensionReviewFormatter -c<path to repo>/rubocop-sketchup/.rubocop_extension.yml

It doesn't make much sense to use the existing .rubocop.yml on a plugin/extension, so I added a file .rubocop_extension.yml, which just runs the SketchUp cops as listed in the manual.

I'll wait on your thoughts re PR #156, and update this.

EDIT: You on vacation?

[thomthom]

So this change is to allow running rubocop with rubocop-sketchup loaded from source without intermediate installs?

[MSP-Greg]

So this change is to allow running rubocop with rubocop-sketchup loaded from source without intermediate installs?

Correct. Users should still be allowed to install it as a gem, but it makes it easier to test with new Ruby/SU versions, and new RuboCop versions.

I'm probably more familiar with 'working with source' than most users...

Let me know if want the merge conflict fixed...

[thomthom]

Let me know if want the merge conflict fixed...

Yes, if you don't mind.