Command title and description #167
Conversation
|
|
||
| require 'spec_helper' | ||
|
|
||
| describe RuboCop::Cop::SketchupSuggestions::CommandTitle do |
There was a problem hiding this comment.
To make this pass the tests we need to change this line to:
describe RuboCop::Cop::SketchupSuggestions::CommandTitle, :config do
And then remove:
subject(:cop) { described_class.new }
There was a problem hiding this comment.
That is what was done to all our existing cops to fix the build:
679d2e2
| end | ||
|
|
||
| # TODO: Add for setter methods. | ||
| # Can we test by how a local variable was defined? Or only by its name? |
There was a problem hiding this comment.
I was thinking something like one node catcher than looks for {x} = UI::Command.new(...) for any x, and then a second search in the same local scope for {x}.menu_text =. Otherwise it can maybe just check for menu_text = and assume there is no other method by the same name.
| text == title_case(text) | ||
| end | ||
|
|
||
| def title_case(text) |
There was a problem hiding this comment.
Worth a comment on how this differ from Ruby's own title case method.
|
|
||
| private | ||
|
|
||
| # REVIEW: Extract to where they can be re-used? |
There was a problem hiding this comment.
Maybe in a lib\rubocop\sketchup\formatting.rb file? A RuboCop::SketchUp::Formatting mixing module?
Like lib\rubocop\sketchup\namespace_checker.rb?
|
Looking good. Did you want to address the |
No description provided.