Fix/dialog width #167
Fix/dialog width #167
Conversation
| :modal => true | ||
| } | ||
| window = SKUI::Window.new(window_options) | ||
| window.background_color = Sketchup::Color.new(240, 240, 240) |
There was a problem hiding this comment.
I wonder why this is needed. Default SKUI is to use system colors. If the user change system color theme this hard coded value might make things look odd...
There was a problem hiding this comment.
It may be a Windows 10 thing.
There was a problem hiding this comment.
I prefer the contrast to the white background.
There was a problem hiding this comment.
Can we deal with the background color in another PR?
At the moment all colors are based on system colors, using system color codes in the CSS stylesheet. I'd rather find a solution where we don't have a mix of hard coded and system colors.
| :modal => true | ||
| } | ||
| window = SKUI::Window.new(window_options) | ||
| window.background_color = Sketchup::Color.new(240, 240, 240) | ||
| list_width = 160 |
There was a problem hiding this comment.
This makes things look ok in SU2017 as well as older versions?
| control.window.close | ||
| } | ||
| btn_cancel.position(-5, -5) | ||
| window.add_control(btn_cancel) | ||
|
|
||
| window.default_button = btn_export |
There was a problem hiding this comment.
Are we setting the cancel button for the dialog?
http://www.rubydoc.info/github/thomthom/SKUI/SKUI/Window#cancel_button-instance_method
There was a problem hiding this comment.
No what does it do? The docs are rather sparse. 😄
There was a problem hiding this comment.
You'd think a developer properly document it's code... tsk tsk...
If I recall correctly setting default/cancel buttons will hook up default triggers for Return/ESC keys.
Technically it's unrelated to this CL, can defer to a separate fix.
| :modal => true | ||
| } | ||
| window = SKUI::Window.new(window_options) | ||
| window.background_color = Sketchup::Color.new(240, 240, 240) |
There was a problem hiding this comment.
Can we deal with the background color in another PR?
At the moment all colors are based on system colors, using system color codes in the CSS stylesheet. I'd rather find a solution where we don't have a mix of hard coded and system colors.
Changes size of export dialog and repositions controls a bit to add a little more space.
For some reason, the SKUI dialog has a smaller width in SketchUp 2017 than it did in previous versions. The dialog was cutting off the drop-down controls and pushing the buttons to the left.