Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fai settings feature branch #1517

Merged
merged 85 commits into from
Jul 2, 2024
Merged

Fai settings feature branch #1517

merged 85 commits into from
Jul 2, 2024

Conversation

chrisfoster76
Copy link
Contributor

No description provided.

chrisfoster76 and others added 30 commits May 29, 2024 12:04
@chrisfoster76
Captures MigratedEmail on account creation
1253b82
@chrisfoster76
New endpoint for create-account inform page WIP
8a83fb2
@chrisfoster76
Implementation
0c3c5d1
@chrisfoster76
Unit test fixes
15a6c42
@balaji-j
New endpoint in the applications controller to get legacy application…
64b875e 
…s by given email address

Story: https://skillsfundingagency.atlassian.net/browse/FAI-1267
@balaji-j
Migrate Endpoints added to migrate legacy application to new FAA
97eb05a
@balaji-j
minor improvements
6e6a691
@chrisfoster76
Sign into your old account WIP
564e6f8
@balaji-j
Minor Improvements to the controller route
0540da3
@chrisfoster76
Outer api implementation
18def1f
@chrisfoster76
Merge branch 'master' into FAI-1266-Login-To-Your-Old-Account
da6f85b 
# Conflicts:
#	src/FindAnApprenticeship/SFA.DAS.FindAnApprenticeship/InnerApi/CandidateApi/Responses/GetApplicationApiResponse.cs
@chrisfoster76
Fixes build error from merge
2e4a624
@dashton82
FAI-1260 - Add email template for send early closure of vacancy
0cc9e21
@balaji-j
Included the handler to import personal details into candidate db as …
9eae47e 
…part of migration
@dashton82
FAI-1260 - Add new email template id for vacancy closed early
254e5ed
@dashton82
FAI-1260 - Add handler for vacancy closed early
1bee6b9
@dashton82
FAI-1260 - Add new controller action for closed early vacancy
1acd43b
@dashton82
FAI-1253 - Stop deploying appsettings.json
97393e7
@dashton82
FAI-1253 - Add resource environment name environment variable to temp…
b1af336 
…late
@balaji-j
Renaming and minor amendments
34c9b8a
@balaji-j
Merged changes from master
8b995fa
@chrisfoster76
Merge branch 'master' into FAI-1266-Login-To-Your-Old-Account
3b21f8f 
# Conflicts:
#	src/FindAnApprenticeship/SFA.DAS.FindAnApprenticeship.Api/AppStart/AddServiceRegistrationExtensions.cs
#	src/FindAnApprenticeship/SFA.DAS.FindAnApprenticeship/Application/Commands/Candidate/CreateCandidateCommandHandler.cs
#	src/FindAnApprenticeship/SFA.DAS.FindAnApprenticeship/InnerApi/CandidateApi/Responses/GetCandidateApiResponse.cs
@dashton82
FAI-1260 - Add patch request to application
e748dce
@dashton82
FAI-1260 - Add application model
f6fa14e
@dashton82
FAI-1260 - Update handler to expire draft vacancies
e2a0667
@dashton82
Merge remote-tracking branch 'origin/master' into FAI-1260-closedearl…
d280a54 
…ynotification
@dashton82
Merge remote-tracking branch 'origin/master' into FAI-1265-Account-Re…
feedc6e 
…covery-Banner
@dashton82
Merge remote-tracking branch 'origin/master' into FAI-1265-Account-Re…
3b0b852 
…covery-Banner
@balaji-j
WIP
b81ca23
@chrisfoster76
Modification to prevent brute-forcing legacy creds
d0976f6
dashton82 and others added 25 commits June 20, 2024 17:50
@dashton82
Merge remote-tracking branch 'origin/FAI-Settings-Feature-Branch' int…
2ad9e1d 
…o FAI-1260-closedearlynotification
@dashton82
Auto stash before merge of "FAI-1260-closedearlynotification" and "or…
d9b4a7f 
…igin/FAI-Settings-Feature-Branch"
@dashton82
FAI-1260 - Fix failing test
244e53c
@SijiOdun
Merge pull request #1495 from SkillsFundingAgency/FAI-1260-closedearl…
fcaf39a 
…ynotification

FAI-1260 Vacancy Closed Early
@chrisfoster76
Merge branch 'master' into FAI-Settings-Feature-Branch
263ad79
@dashton82
FAI-1320 - Make one less API call for data we already have
9b07835
@dashton82
Merge remote-tracking branch 'origin/master' into FAI-Settings-Featur…
3d813c8 
…e-Branch
@dashton82
FAI-1320 - fix failing tests
2162b2d
@dashton82
Fix package scan warnings
4b921f7
@dashton82
Make sure migrated email is set through unhappy recovery path
0eb6227
@dashton82
Merge remote-tracking branch 'origin/master' into FAI-Settings-Featur…
449f1ae 
…e-Branch
@dashton82
Add first name and last name to data returned for migration
7112401
@dashton82
Change queryhandler to get legacy and existing candidate data
0a81534
@dashton82
Change migration handler to map address correctly
ad82311
@dashton82
Merge remote-tracking branch 'origin/master' into FAI-Settings-Featur…
f5ceb9b 
…e-Branch
@dashton82
FAI-1267 - Add get postcode query for migration journey
d467c3a
@dashton82
FAI-1267 - Add endpoint to get postcode for candidate
fe7be26
@dashton82
Change candidateid to come from route
97673db
@dashton82
FAI-1316 - update email address when viewing settings
ca95a7b
@dashton82
FAI-1316 - missed commit
a976093
@dashton82
FAI-1316 - fix test that was failing not through ide
08c74dd
@dashton82
FAI-1269 - Fix banner not showing on application
80be299
@dashton82
Ensure email is being updated if has changed
4eb165e
@dashton82
FAI-1316 - return correct email when email changed
beb7052
@dashton82
Merge remote-tracking branch 'origin/master' into FAI-Settings-Featur…
5ef7677 
…e-Branch
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Failed Quality Gate failed for 'das-apim-endpoints-FindApprenticeshipJobs'

Failed conditions
78.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-FindAnApprenticeship'

Issues
27 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.0% Coverage on New Code
0.6% Duplication on New Code

See analysis details on SonarCloud

@SijiOdun SijiOdun merged commit fc38d0c into master Jul 2, 2024
56 of 57 checks passed
@SijiOdun SijiOdun deleted the FAI-Settings-Feature-Branch branch July 2, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balaji-j balaji-j balaji-j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrisfoster76 @balaji-j @SijiOdun @dashton82