Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csp 1367 update pr api call in reservations outer #1522

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Csp 1367 update pr api call in reservations outer #1522

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e42c2d8
CSP-1390 - Updated request url and to not hard code the operations list
PeterDavidWilliams Jun 20, 2024
7f0a164
CSP-1390 - Replaced duplicate call with existing call
PeterDavidWilliams Jun 20, 2024
f5d5a71
CSP-1367 - Updated url in unit test
PeterDavidWilliams Jun 20, 2024
78b99b0
Merge branch 'master' into CSP-1367-UpdatePRApiCallInReservationsOuter
PeterDavidWilliams Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ation/ProviderAccounts/WhenHandlingGetProviderAccountLegalEntitiesWithCreatCohortQuery.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
using NUnit.Framework;
using SFA.DAS.Reservations.Application.ProviderAccounts.Queries;
using SFA.DAS.SharedOuterApi.Configuration;
using SFA.DAS.SharedOuterApi.InnerApi.Requests.ProviderPermissions;
using SFA.DAS.SharedOuterApi.InnerApi.Requests;
using SFA.DAS.SharedOuterApi.Interfaces;
using SFA.DAS.Testing.AutoFixture;

Expand All @@ -23,9 +23,9 @@ public class WhenHandlingGetProviderAccountLegalEntitiesWithCreatCohortQuery
{
apiClient.Setup(x =>
x.Get<GetProviderAccountLegalEntitiesWithCreateCohortResult>(
It.Is<GetProviderAccountLegalEntitiesWithCreatCohortRequest>(c => c.GetUrl.Contains($"ukprn={withCreatCohortQuery.Ukprn}"))))
It.Is<GetProviderAccountLegalEntitiesRequest>(c => c.GetUrl.Contains($"ukprn={withCreatCohortQuery.Ukprn}"))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add cohort here in the request

.ReturnsAsync(apiQueryResponse);

var actual = await handler.Handle(withCreatCohortQuery, CancellationToken.None);

actual.AccountProviderLegalEntities.Should().BeEquivalentTo(apiQueryResponse.AccountProviderLegalEntities);
Expand Down
6 changes: 4 additions & 2 deletions ...on/ProviderAccounts/Queries/GetProviderAccountLegalEntitiesWithCreatCohortQueryHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using MediatR;
using SFA.DAS.SharedOuterApi.Configuration;
using SFA.DAS.SharedOuterApi.InnerApi.Requests.ProviderPermissions;
using SFA.DAS.SharedOuterApi.InnerApi.Requests;
using SFA.DAS.SharedOuterApi.Interfaces;
using SFA.DAS.SharedOuterApi.Models.ProviderRelationships;

namespace SFA.DAS.Reservations.Application.ProviderAccounts.Queries;

Expand All @@ -12,6 +14,6 @@ public class GetProviderAccountLegalEntitiesWithCreatCohortQueryHandler(IProvide
{
public async Task<GetProviderAccountLegalEntitiesWithCreateCohortResult> Handle(GetProviderAccountLegalEntitiesWithCreatCohortQuery request, CancellationToken cancellationToken)
{
return await apiClient.Get<GetProviderAccountLegalEntitiesWithCreateCohortResult>(new GetProviderAccountLegalEntitiesWithCreatCohortRequest(request.Ukprn));
return await apiClient.Get<GetProviderAccountLegalEntitiesWithCreateCohortResult>(new GetProviderAccountLegalEntitiesRequest(request.Ukprn, new List<Operation> { Operation.CreateCohort }));
}
}
15 changes: 0 additions & 15 deletions ...Api/Requests/ProviderPermissions/GetProviderAccountLegalEntitiesWithCreatCohortRequest.cs
View file
Open in desktop

This file was deleted.

Loading