Runtime error for when EffSort aborts due to null value #8206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swap reset and delete errors
Co-authored-by: sovdee <[email protected]>
Fix incorrect change processing order
change parameter name
…ments (SkriptLang#8189) Account for functions with all optional parameters
modify section context when parsing functions
sovdeeth
added
the
bug
sovdeeth
requested review from
Burbulinis and
cheeezburga
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
erenkarakal
approved these changes
Sep 26, 2025
APickledWalrus
approved these changes
Sep 30, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.13 Releases
skriptlang-automation
bot
added
feature-ready
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.13 Releases
skriptlang-automation
bot
added
the
completed
skriptlang-automation
bot
removed
the
feature-ready
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
) * Swap reset and delete errors in EffChange (SkriptLang#8177) swap reset and delete errors * Fix improper grammar in update block syntax (SkriptLang#8072) Co-authored-by: sovdee <[email protected]> * Fix Incorrect Variable Change Queue Processing (SkriptLang#8182) Fix incorrect change processing order * Change registerExpression() parameter name (SkriptLang#8180) change parameter name * Move EvtRealTime to main thread (SkriptLang#8185) * Fix type-aware function parsing for functions with only optional arguments (SkriptLang#8189) Account for functions with all optional parameters * Properly parse exprsecs in function calls (SkriptLang#8199) modify section context when parsing functions * add runtime error when EffSort aborts due to null values. * catch runtime errors
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
) * Swap reset and delete errors in EffChange (SkriptLang#8177) swap reset and delete errors * Fix improper grammar in update block syntax (SkriptLang#8072) Co-authored-by: sovdee <[email protected]> * Fix Incorrect Variable Change Queue Processing (SkriptLang#8182) Fix incorrect change processing order * Change registerExpression() parameter name (SkriptLang#8180) change parameter name * Move EvtRealTime to main thread (SkriptLang#8185) * Fix type-aware function parsing for functions with only optional arguments (SkriptLang#8189) Account for functions with all optional parameters * Properly parse exprsecs in function calls (SkriptLang#8199) modify section context when parsing functions * add runtime error when EffSort aborts due to null values. * catch runtime errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
EffSort would silently fail when encountering a null value, leading to confusion about why the list wasn't being sorted.
Solution
Adds a runtime error when this occurs that explains what happens and what input returned null.
Testing Completed
Manual testing. Failing test will be fixed when #8195 is merged.
Supporting Information
Reported in skUnity discord.
Completes: none
Related: none