Improve ExpressionList#acceptChange, implement #changeInPlace #8211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
sovdeeth
added
the
enhancement
skriptlang-automation
bot
added
the
needs reviews
Absolutionism
requested changes
Sep 29, 2025
Absolutionism
approved these changes
Sep 29, 2025
APickledWalrus
approved these changes
Sep 30, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.13 Releases
skriptlang-automation
bot
added
patch-ready
skriptlang-automation
bot
added
the
completed
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.13 Releases
skriptlang-automation
bot
removed
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ExpressionList didn't accurately return the right acceptChange classes, it was too conservative. Subexpressions needed to accept the same Class, rather than checking for subclasses and returning the lowest common denominator.
Solution
Each subexpression is checked to see which of its acceptChange values are compatible with the previously determined values. When a match is found, the more specific type is taken, to avoid issues with a superclass being returned, but the exprs only accepting a specific subclass.
Testing Completed
Supporting Information
Completes: none
Related: none