-
-
Notifications
You must be signed in to change notification settings - Fork 416
Food Components #8218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Absolutionism
wants to merge
6
commits into
SkriptLang:dev/feature
Choose a base branch
from
Absolutionism:dev/FoodComponents
base: dev/feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Food Components #8218
Absolutionism
wants to merge
6
commits into
SkriptLang:dev/feature
from
Absolutionism:dev/FoodComponents
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
requested changes
Oct 26, 2025
...ain/java/org/skriptlang/skript/bukkit/itemcomponents/food/elements/EffFoodCompAlwaysEat.java
Outdated
Show resolved
Hide resolved
...in/java/org/skriptlang/skript/bukkit/itemcomponents/food/elements/ExprFoodCompNutrition.java
Outdated
Show resolved
Hide resolved
...n/java/org/skriptlang/skript/bukkit/itemcomponents/food/elements/ExprFoodCompSaturation.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/itemcomponents/food/elements/ExprFoodComponent.java
Outdated
Show resolved
Hide resolved
...ain/java/org/skriptlang/skript/bukkit/itemcomponents/food/elements/ExprSecBlankFoodComp.java
Outdated
Show resolved
Hide resolved
Efnilite
reviewed
Nov 2, 2025
...ain/java/org/skriptlang/skript/bukkit/itemcomponents/food/elements/EffFoodCompAlwaysEat.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/itemcomponents/food/elements/ExprFoodComponent.java
Outdated
Show resolved
Hide resolved
sovdeeth
reviewed
Nov 7, 2025
...in/java/org/skriptlang/skript/bukkit/itemcomponents/food/elements/CondFoodCompAlwaysEat.java
Show resolved
Hide resolved
sovdeeth
approved these changes
Nov 7, 2025
Member
sovdeeth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good with efy's changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.14
Targeting a 2.14.X version release.
feature
Pull request adding a new feature.
needs reviews
A PR that needs additional reviews
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Skript does not yet have support for Food Components, otherwise known as FoodProperties. Skript should include this since it's vanilla.
Solution
Adds a new
FoodModulewithinitemcomponentsthat's designated for all classes and elements relating to the Food Component.Adds
FoodWrapperthat extendsComponentWrapperand handles retrieving and modifying data on the wrappedFoodPropertiescomponent.Adds
FoodExperimentalSyntaxto be implemented on all elements dealing with FoodWrapper.Adds elements for all retrievable and changeable data on a
FoodPropertiesTesting Completed
FoodComponents.skSupporting Information
N/A
Completes: none
Related: none