-
-
Notifications
You must be signed in to change notification settings - Fork 416
[BUG] Resolved Auto reload case sensitive issue. #8293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HarshMehta112
wants to merge
4
commits into
SkriptLang:dev/patch
Choose a base branch
from
HarshMehta112:master
base: dev/patch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Mehta <[email protected]>
Member
|
Hi, please use the proper PR template. You should be able to edit your description to amend it. |
sovdeeth
requested changes
Nov 22, 2025
sovdeeth
approved these changes
Nov 22, 2025
Member
sovdeeth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The recipient != null check technically isn't necessary (the @nullable should be on ... instead of on String) but that's not something you have to fix here.
erenkarakal
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
An issue that needs to be fixed. Alternatively, a PR fixing an issue.
patch-ready
A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix case-sensitivity bug in auto reload recipients (#8290)
Description:
This PR makes the matching of auto reload recipients case-insensitive. Previously, usernames had to match exactly in case for reload notifications to work — now, any case variation will be accepted.
Changes:
Normalize recipient strings (e.g. to lowercase) for comparison
Preserve original case for display if needed
Fixes: #8290