refactoring for SkyApm.Transport.Protocol#584
Conversation
lu-xiaoshuang
commented
Mar 27, 2024
- Why submit this pull request?
- [*] refactoring
|
Please fix the CI. |
85b3319 to
aa3fdde
Compare
|
CI issue fixed |
|
Mark this on 2.3.0, as @liuhaoyang is planning to run 2.2.0 release, we should stop adding new things. |
|
Hi @liuhaoyang , would you please review this pull request? |
|
Why do we need this? Please explain your proposal. |
reporter interface layer needs an independent dotnet project. Both gRPC reporter and Kafka reporter are concrete implementations which live in their own project directories. |
|
We don't have Kafka reporter AFAIK. Nother to be shared. |
|
|
That thing had no progress for over half of the year. So, I closed that. I don't know what happened. |
What about this plan for kafka reporter? |
|
All others are closed, how close are they ready to be accepted? @liuhaoyang |
|
@lu-xiaoshuang We have merged this, please update reporter part. |
Copy. Please reopen #559 ~ |
|
You could open a new one with a clear context and including this change. |
okay. |