-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Fix compilation error due to DirectionType redifinition #2
FIX: Fix compilation error due to DirectionType redifinition #2
Conversation
Thanks! |
Thanks Michael. Is there an easy way for me to merge this into the gitlab repo? |
I will make a PR into gitlab repository. |
Merge request in gitlab |
Unfortunately this breaks CUDA. I will work on an alternate solution. |
Apparently I cannot re-open an issue that I didn't create. But please consider it to be re-opened. |
I can't re-open it, but i can create a new pull request to revert these changes. |
I have a new fix for this in 753f6adb and eeb0884f. Can you check if this will work? How can I easily make a pull request from gitlab? |
I think there is no need to revert, I merged yours, this will update from there. |
I've checked gitlab updates, and both SlicerRT and Plastimatch were compiled successfully. |
Update: I've only tested in Linux, and i don't have CUDA. |
I've cherry picked these two cuda commits, and i will try to create a pull request, and eventually update SlicerRT Plastimatch cmake file. |
@gregsharp Could you check that #3 is OK, and my cherry picking is correct? |
Linux: https://slicer.cdash.org/build/2828610
Windows: https://slicer.cdash.org/build/2828808
Mac: https://slicer.cdash.org/build/2828797