-
Notifications
You must be signed in to change notification settings - Fork 1
Add auto generated HTML pages #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Took 10 hours 1 minute
Took 47 minutes
Cleaned up scss Took 3 hours 22 minutes
Took 17 minutes
Took 4 minutes
Took 2 hours 15 minutes
Took 55 minutes
Took 1 hour 2 minutes
Took 29 minutes
Fixed page-material padding incorrectly applying to the title Took 10 minutes
Took 2 hours 27 minutes
Took 15 minutes
Took 26 minutes
Took 15 minutes
Took 41 minutes
Something important to note: I don't want to replace the existing picture based books with HTML ones. I would rather have both. The reason is the image ones are way more likely to be stable on the chance the HTML updater breaks in the future, and are way more likely to be accurate across devices. You will likely want a separate home page for HTML books vs image books, with links between the two as relevant. |
Would it be better for the HTML books to be the primary, and the image books to be the fallback in case of any issues? |
Neither is really primary or fallback. They are just different pages. The book index can link them both: Icon Key thing is I want to have both. I find images works very nicely on mobile notably. |
Took 59 minutes
Took 5 minutes
Took 1 hour 9 minutes
Took 7 seconds
Took 2 minutes
Took 31 minutes
Took 11 minutes Took 7 minutes
Took 15 minutes
Took 1 hour 8 minutes
Took 1 hour 13 minutes
Took 1 hour 15 minutes
Compressed remaining images Took 29 minutes
Ok so I put back the image books and separated the HTML book pages, theres just one more issue with fluid effects I need to fix |
Took 14 minutes
Fixed resizing flashes Took 2 hours 26 minutes
Took 1 hour 43 minutes
Took 3 hours 5 minutes
Took 19 minutes
Took 18 minutes
6e6ac6b
to
5dcbe5f
Compare
Took 1 hour 33 minutes
Took 6 minutes
Moved title to books.yml Cleaned up some css
Took 1 hour 12 minutes
Took 13 minutes
Took 1 hour 9 minutes
Reformatted js Took 48 minutes
Took 5 minutes
Took 6 minutes
Updated header Took 13 minutes
Took 16 minutes
Took 4 hours 11 minutes
Took 21 minutes
I think I'm pretty close to being done, so here's what I have. There's definitely even more that can be done, like the tooltips we talked about, but that will have to be for later.
Preview: https://paypur.github.io/docs/books/1.20/
Tinkers' PR: SlimeKnights/TinkersConstruct#5456
Mantle PR: SlimeKnights/Mantle#231
Notes
PageContent
needs to overridetoHTML
Exporting HTML piggybacks off of the/mantle book export
but can be split into its own commandscale = 2
, but this should be easy to changeLoading images needs to download quite a lot of data (the encyclopedia is at 7MB if I remove the duplicated images, but image compression should help a lot)The book "chapters" feel kinda redundant now that we can just link to a specific page on an imageStill TODOs
FixContentListing
s overflowingCompress the .png'sRemove old images (at least for 1.20.1)Add back the previous page layout for old versionsFix issues on mobileRebase before we merge