things I got pinged about to fix (#803)

SlimeVR · Aug 3, 2023 · 93c910b · 93c910b
1 parent 06520b9
commit 93c910b
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/gui/public/i18n/en/translation.ftl b/gui/public/i18n/en/translation.ftl
@@ -783,9 +783,9 @@ onboarding-automatic_proportions-check_height-fetch_height = I'm standing!
 # Context is that the height is unknown
 onboarding-automatic_proportions-check_height-unknown = Unknown
 # Shows an element below it
-onboarding-automatic_proportions-check_height-height = Your height is
+onboarding-automatic_proportions-check_height-hmd_height1 = Your HMD height is
 # Shows an element below it
-onboarding-automatic_proportions-check_height-hmd_height = And HMD height is
+onboarding-automatic_proportions-check_height-height1 = so your actual height is
 onboarding-automatic_proportions-check_height-next_step = They are fine
 onboarding-automatic_proportions-start_recording-title = Get ready to move
 onboarding-automatic_proportions-start_recording-description = We're now going to record some specific poses and moves. These will be prompted in the next screen. Be ready to start when the button is pressed!

diff --git a/gui/src/components/commons/NumberSelector.tsx b/gui/src/components/commons/NumberSelector.tsx
@@ -34,7 +34,7 @@ export function NumberSelector({
       render={({ field: { onChange, value } }) => (
         <div className="flex flex-col gap-1 w-full">
           <Typography bold>{label}</Typography>
-          <div className="flex gap-2 bg-background-60 p-2 rounded-lg">
+          <div className="flex gap-5 bg-background-60 p-2 rounded-lg">
             <div className="flex">
               <Button
                 variant="tertiary"

diff --git a/gui/src/components/onboarding/pages/body-proportions/autobone-steps/СheckHeight.tsx b/gui/src/components/onboarding/pages/body-proportions/autobone-steps/СheckHeight.tsx
@@ -117,9 +117,9 @@ export function CheckHeight({
           <form className="flex flex-col self-center items-center justify-center">
             <NumberSelector
               control={control}
-              name="height"
+              name="hmdHeight"
               label={l10n.getString(
-                'onboarding-automatic_proportions-check_height-height'
+                'onboarding-automatic_proportions-check_height-hmd_height1'
               )}
               valueLabelFormat={(value) =>
                 isNaN(value)
@@ -131,12 +131,13 @@ export function CheckHeight({
               min={MIN_HEIGHT}
               max={4}
               step={0.01}
+              disabled={true}
             />
             <NumberSelector
               control={control}
-              name="hmdHeight"
+              name="height"
               label={l10n.getString(
-                'onboarding-automatic_proportions-check_height-hmd_height'
+                'onboarding-automatic_proportions-check_height-height1'
               )}
               valueLabelFormat={(value) =>
                 isNaN(value)
@@ -148,7 +149,6 @@ export function CheckHeight({
               min={MIN_HEIGHT}
               max={4}
               step={0.01}
-              disabled={true}
             />
           </form>
         </div>

diff --git a/gui/src/components/settings/pages/Serial.tsx b/gui/src/components/settings/pages/Serial.tsx
@@ -219,7 +219,7 @@ export function Serial() {
           </div>
           <div className="" ref={toolbarRef}>
             <div className="border-t-2 pt-2  border-background-60 border-solid m-2 gap-2 flex flex-row">
-              <div className="flex flex-grow gap-2 mobile:grid mobile:grid-cols-2  mobile:grid-rows-2">
+              <div className="flex flex-grow flex-wrap gap-2 mobile:grid mobile:grid-cols-2 mobile:grid-rows-2">
                 <Button variant="quaternary" onClick={reboot}>
                   {l10n.getString('settings-serial-reboot')}
                 </Button>

diff --git a/gui/src/components/tracker/TrackerBattery.tsx b/gui/src/components/tracker/TrackerBattery.tsx
@@ -24,6 +24,7 @@ export function TrackerBattery({
   });
   const voltageFormatter = new Intl.NumberFormat(currentLocales, {
     maximumFractionDigits: 2,
+    minimumFractionDigits: 2,
   });
 
   return (