-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Remote Command Over WiFi #255
Open
nekomona
wants to merge
10
commits into
SlimeVR:main
Choose a base branch
from
nekomona:rcmd_merge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4d5eff0
Add remote command through telnet
nekomona 6ba519c
Code formatting
nekomona 63256b0
Add define switch for remote console
nekomona 10b3a3e
Pushing through clang-format
nekomona f04cc66
Add IP check for remote command
nekomona 3938ce5
Fix IP check and provision check
nekomona 2d92da3
Add IP check for remote command
nekomona b08d080
Fix IP check and provision check
nekomona 8d7d64c
Add remote command to feature flag list
nekomona 5e9db36
Update src/serial/serialcommands.cpp
nekomona File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
#include <Arduino.h> | ||
|
||
#include "GlobalVars.h" | ||
|
||
namespace SlimeVR { | ||
namespace Logging { | ||
bool getRemoteCmdConncted() { return networkRemoteCmd.isConnected() && networkConnection.isConnected(); } | ||
|
||
Stream& getRemoteCmdStream() { return networkRemoteCmd.getStream(); } | ||
} // namespace Logging | ||
} // namespace SlimeVR |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
#ifndef LOGGING_RETOMELOGHELPER_H | ||
#define LOGGING_RETOMELOGHELPER_H | ||
|
||
#include <Arduino.h> | ||
|
||
namespace SlimeVR { | ||
namespace Logging { | ||
bool getRemoteCmdConncted(); | ||
Stream& getRemoteCmdStream(); | ||
} // namespace Logging | ||
} // namespace SlimeVR | ||
|
||
#endif // LOGGING_RETOMELOGHELPER_H |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
#include "remotecmd.h" | ||
|
||
#include "GlobalVars.h" | ||
|
||
namespace SlimeVR { | ||
namespace Network { | ||
|
||
void RemoteCmd::reset() { | ||
rcmdClient = WiFiClient(); | ||
rcmdServer.begin(); | ||
} | ||
|
||
void RemoteCmd::update() { | ||
// Check for new connections to remote command | ||
if (rcmdServer.hasClient()) { | ||
if (rcmdClient.connected()) { | ||
// Connection already exists, drop the new one | ||
rcmdServer.accept().stop(); | ||
r_Logger.info("Remote command multi-connection dropped"); | ||
} else { | ||
IPAddress rejectedIP; | ||
rcmdClient = rcmdServer.accept(); | ||
if (networkConnection.isConnected()) { | ||
// Only accept if rcmdClient have the same remote IP as udpmanager | ||
if (rcmdClient.remoteIP() != networkConnection.m_ServerHost) { | ||
rejectedIP = rcmdClient.remoteIP(); | ||
rcmdClient.stop(); | ||
} | ||
} | ||
#if !ALLOW_REMOTE_WIFI_PROV | ||
else { | ||
rejectedIP = rcmdClient.remoteIP(); | ||
rcmdClient.stop(); | ||
} | ||
#endif | ||
if (rcmdClient.connected()) { | ||
r_Logger.info( | ||
"Remote command from %s connected", | ||
rcmdClient.remoteIP().toString().c_str() | ||
); | ||
} else { | ||
r_Logger.info( | ||
"Remote command from %s dropped", | ||
rejectedIP.toString().c_str() | ||
); | ||
} | ||
} | ||
} | ||
} | ||
|
||
bool RemoteCmd::isConnected() { return rcmdClient.connected(); } | ||
|
||
Stream& RemoteCmd::getStream() { return rcmdClient; } | ||
|
||
} // namespace Network | ||
} // namespace SlimeVR |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
SlimeVR Code is placed under the MIT license | ||
Copyright (c) 2023 SlimeVR Contributors | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in | ||
all copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
THE SOFTWARE. | ||
*/ | ||
#ifndef SLIMEVR_NETWORK_REMOTECMD_H_ | ||
#define SLIMEVR_NETWORK_REMOTECMD_H_ | ||
|
||
#include <WiFiClient.h> | ||
#include <WiFiServer.h> | ||
|
||
#include "globals.h" | ||
#include "logging/Logger.h" | ||
|
||
namespace SlimeVR { | ||
namespace Network { | ||
|
||
class RemoteCmd { | ||
public: | ||
void reset(); | ||
void update(); | ||
|
||
bool isConnected(); | ||
Stream& getStream(); | ||
|
||
private: | ||
SlimeVR::Logging::Logger r_Logger = SlimeVR::Logging::Logger("RemoteCmd"); | ||
|
||
WiFiServer rcmdServer = WiFiServer(23); | ||
WiFiClient rcmdClient; | ||
}; | ||
|
||
} // namespace Network | ||
} // namespace SlimeVR | ||
|
||
#endif // SLIMEVR_NETWORK_REMOTECMD_H_ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this really be 0? Is there a reason we started at 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just from that the first version of remote command is written before WiFi scanning