Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET.INFO Serial Command Should Returns Battery Voltage & Level (in Percentages) #338

Merged
merged 2 commits into from
Sep 1, 2024
Merged

GET.INFO Serial Command Should Returns Battery Voltage & Level (in Percentages) #338

merged 2 commits into from
Sep 1, 2024

Conversation

ZycaR
Copy link
Contributor

@ZycaR ZycaR commented Aug 19, 2024 •
edited
Loading

This update modifies the GET INFO serial command to include battery voltage and battery level (displayed as a percentage).

This enhancement provides detailed battery status information in the serial output and was a big help when I was troubleshooting a connection issue with the battery sense wire.

@ZycaR ZycaR changed the title GET.INFO serial command returns also battery voltage & level (in percents) GET.INFO Serial Command Now Returns Battery Voltage & Level (in Percentages) Aug 19, 2024
@ZycaR ZycaR changed the title GET.INFO Serial Command Now Returns Battery Voltage & Level (in Percentages) GET.INFO Serial Command Should Returns Battery Voltage & Level (in Percentages) Aug 19, 2024
Vyolex
Vyolex requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@Vyolex Vyolex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a useful change

src/batterymonitor.h Outdated Show resolved Hide resolved
@ZycaR ZycaR requested a review from Vyolex September 1, 2024 09:56
TheDevMinerTV
TheDevMinerTV approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@TheDevMinerTV TheDevMinerTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ButterscotchV ButterscotchV merged commit 8b00064 into SlimeVR:main Sep 1, 2024
1 check passed
@ZycaR ZycaR deleted the GET-INFO-CMD-AddBaterryInfo branch September 3, 2024 20:23
kounocom added a commit to kounocom/SlimeVR-Tracker-ESP that referenced this pull request Oct 11, 2024
@kounocom
Squashed commit of the following:
9d17241 
commit f1ac5aa
Author: kounocom <[email protected]>
Date:   Fri Oct 11 17:02:48 2024 +0300

    ...and finally, change whatever these do

commit 2ef6306
Author: kounocom <[email protected]>
Date:   Fri Oct 11 16:58:25 2024 +0300

    ...and then light the LED when rest is detected, as a debug step

commit 4950a17
Author: kounocom <[email protected]>
Date:   Fri Oct 11 16:56:03 2024 +0300

    ...and then make them actually work per-sensor

commit 1faff26
Author: kounocom <[email protected]>
Date:   Fri Oct 11 16:54:54 2024 +0300

    ...and some more

commit 2f2c248
Author: kounocom <[email protected]>
Date:   Fri Oct 11 16:54:09 2024 +0300

    Adjust VQF params more

commit afb4d32
Author: gorbit99 <[email protected]>
Date:   Tue Oct 8 18:33:54 2024 +0200

    Whoops

commit 3d9ad76
Author: gorbit99 <[email protected]>
Date:   Tue Oct 8 18:27:55 2024 +0200

    Zero out accel calibration

commit 5222085
Author: gorbit99 <[email protected]>
Date:   Tue Oct 8 18:25:53 2024 +0200

    ACTUALLY skip accel calibration

commit ea5ea1a
Merge: 1e47ff7 099fd9a
Author: gorbit99 <[email protected]>
Date:   Tue Oct 8 18:06:25 2024 +0200

    Merge branch 'dynamic-sfusion' of https://github.com/kounocom/SlimeVR-Tracker-ESP into dynamic-sfusion

commit 1e47ff7
Author: gorbit99 <[email protected]>
Date:   Tue Oct 8 17:56:29 2024 +0200

    Increase sensitivity when gyro is calibrated + skip accel calibration for now

commit 099fd9a
Author: kounocom <[email protected]>
Date:   Wed Oct 2 08:48:46 2024 +0300

    Stuffs for dynamic

commit 6f74905
Merge: 44e2aaf 6eb1ef9
Author: gorbit99 <[email protected]>
Date:   Wed Oct 2 07:29:34 2024 +0200

    Merge branch 'icm45686-firmware' into dynamic-sfusion

commit 6eb1ef9
Author: kounocom <[email protected]>
Date:   Wed Oct 2 07:39:19 2024 +0300

    Use correct sensitivity

commit b84096c
Merge: 6515014 73faa41
Author: gorbit99 <[email protected]>
Date:   Wed Oct 2 03:59:36 2024 +0200

    Merge branch 'icm45686-firmware' of https://github.com/gorbit99/SlimeVR-Tracker-ESP into icm45686-firmware

commit 6515014
Author: gorbit99 <[email protected]>
Date:   Wed Oct 2 03:59:24 2024 +0200

    Hires mode maybe?

commit 73faa41
Author: kounocom <[email protected]>
Date:   Wed Oct 2 03:11:08 2024 +0300

    Sleep more

commit 1aae55a
Author: kounocom <[email protected]>
Date:   Wed Oct 2 03:00:55 2024 +0300

    Use 8KB FIFO

commit bc65001
Author: kounocom <[email protected]>
Date:   Wed Oct 2 02:50:59 2024 +0300

    Use clock

commit eec8ac6
Author: gorbit99 <[email protected]>
Date:   Tue Oct 1 23:56:46 2024 +0200

    Actually enable FIFO this time

commit 44e2aaf
Author: kounocom <[email protected]>
Date:   Tue Oct 1 21:06:15 2024 +0300

    This works better

commit db71a05
Author: kounocom <[email protected]>
Date:   Mon Sep 30 17:03:19 2024 +0300

    change to 4g, fill in missing stuff elsewhere

commit f219cc3
Author: kounocom <[email protected]>
Date:   Sun Sep 29 09:58:35 2024 +0300

    Always limit TPS with aux (now to 90)

commit 8a63326
Author: gorbit99 <[email protected]>
Date:   Wed Sep 25 21:09:51 2024 +0200

    In theory this works?

commit dbce4cb
Author: Butterscotch! <[email protected]>
Date:   Wed Sep 25 12:02:37 2024 -0400

    Add dependabot & update workflows (SlimeVR#344)

    * Add dependabot & update workflows

    * Specify python-version & use pip cache

    * Add requirements.txt

    * Cache PIP generally instead & remove requirements

commit 8b00064
Author: Ondrej Hruska <[email protected]>
Date:   Sun Sep 1 10:46:47 2024 -0700

    GET.INFO Serial Command Should Returns Battery Voltage & Level (in Percentages) (SlimeVR#338)

    * GET.INFO serial command return also battery voltage & level in percents

    * move public headers together
kounocom added a commit to kounocom/SlimeVR-Tracker-ESP that referenced this pull request Oct 11, 2024
@kounocom
Squashed commit of the following:
7f8c981 
commit e2e1880
Merge: f7fc1ce 86915b1
Author: kounocom <[email protected]>
Date:   Fri Oct 11 18:10:11 2024 +0300

    Merge branch 'icm45686-firmware' of https://github.com/gorbit99/SlimeVR-Tracker-ESP into icm45686-firmware

commit 86915b1
Author: gorbit99 <[email protected]>
Date:   Mon Oct 7 08:27:51 2024 +0200

    Fix incorrect number in IMU name

commit 4abf06f
Author: gorbit99 <[email protected]>
Date:   Sat Oct 5 04:46:42 2024 +0200

    Remove unnecessary changes

commit 4680248
Author: gorbit99 <[email protected]>
Date:   Wed Oct 2 09:02:21 2024 +0200

    ICM45686 implementation

commit f7fc1ce
Author: kounocom <[email protected]>
Date:   Wed Oct 2 08:00:31 2024 +0300

    Make sensor reset work (lol)

commit 6eb1ef9
Author: kounocom <[email protected]>
Date:   Wed Oct 2 07:39:19 2024 +0300

    Use correct sensitivity

commit b84096c
Merge: 6515014 73faa41
Author: gorbit99 <[email protected]>
Date:   Wed Oct 2 03:59:36 2024 +0200

    Merge branch 'icm45686-firmware' of https://github.com/gorbit99/SlimeVR-Tracker-ESP into icm45686-firmware

commit 6515014
Author: gorbit99 <[email protected]>
Date:   Wed Oct 2 03:59:24 2024 +0200

    Hires mode maybe?

commit 73faa41
Author: kounocom <[email protected]>
Date:   Wed Oct 2 03:11:08 2024 +0300

    Sleep more

commit 1aae55a
Author: kounocom <[email protected]>
Date:   Wed Oct 2 03:00:55 2024 +0300

    Use 8KB FIFO

commit bc65001
Author: kounocom <[email protected]>
Date:   Wed Oct 2 02:50:59 2024 +0300

    Use clock

commit eec8ac6
Author: gorbit99 <[email protected]>
Date:   Tue Oct 1 23:56:46 2024 +0200

    Actually enable FIFO this time

commit db71a05
Author: kounocom <[email protected]>
Date:   Mon Sep 30 17:03:19 2024 +0300

    change to 4g, fill in missing stuff elsewhere

commit 8a63326
Author: gorbit99 <[email protected]>
Date:   Wed Sep 25 21:09:51 2024 +0200

    In theory this works?

commit dbce4cb
Author: Butterscotch! <[email protected]>
Date:   Wed Sep 25 12:02:37 2024 -0400

    Add dependabot & update workflows (SlimeVR#344)

    * Add dependabot & update workflows

    * Specify python-version & use pip cache

    * Add requirements.txt

    * Cache PIP generally instead & remove requirements

commit 8b00064
Author: Ondrej Hruska <[email protected]>
Date:   Sun Sep 1 10:46:47 2024 -0700

    GET.INFO Serial Command Should Returns Battery Voltage & Level (in Percentages) (SlimeVR#338)

    * GET.INFO serial command return also battery voltage & level in percents

    * move public headers together
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@Vyolex Vyolex Vyolex approved these changes

@TheDevMinerTV TheDevMinerTV TheDevMinerTV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZycaR @ButterscotchV @Vyolex @TheDevMinerTV