Fixes #4020 #4193
Open
Fixes #4020 #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Pull Request was automatically labelled as: "✨ Fix" |
JustAHuman-xD
requested changes
May 30, 2024
Comment on lines
+496
to
+508
| if (itemMeta instanceof BookMeta itemBookMeta && sfitemMeta instanceof BookMeta sfItemBookMeta) { | ||
| if(itemBookMeta.getAuthor() != sfItemBookMeta.getAuthor()) | ||
| return false; | ||
| if(itemBookMeta.getTitle() != sfItemBookMeta.getTitle()) | ||
| return false; | ||
| if(itemBookMeta.getPageCount() != sfItemBookMeta.getPageCount()) | ||
| return false; | ||
| } | ||
|
|
||
| if (itemMeta instanceof SkullMeta itemHeadMeta && sfitemMeta instanceof SkullMeta sfItemHeadMeta) { | ||
| if(itemHeadMeta.getOwningPlayer() != sfItemHeadMeta.getOwningPlayer()) | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Other than the codestyle this looks good, only thing I think is wrong is the if statements are missing brackets and some spaces.
Other than that functionally its probably okay but you can inline the returns to be like
return itemBookMeta.getAuthor().equals(sfItemBookMeta.getAuthor() && etc etc
or
return itemHeadMeta.getOwningPlayer().equals(sfItemHeadMeta.getOwningPlayer());
I'm not 100% sure that the player check is a good idea since it's nullable iirc, so you might need to change that, I'd have to check to be completely sure
Dinnerwolph
force-pushed
the
fix/CargoMetadata
branch
from
81d828d
to
d4ae0ba
Compare
TheBusyBot
added
the
⚡ Merge Conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposed changes
Related Issues (if applicable)
Resolves #4020
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values