Update to 1.21 #4248

WalshyDev · 2024-10-01T00:23:07Z

Description

Updates to 1.21 - big shout out to MockBukkit team and @Intybyte for the work on tests

Proposed changes

Updated Slimefun code to support 1.21

Related Issues (if applicable)

N/A

Checklist

I have fully tested the proposed changes and promise that they will not break everything into chaos.
I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
I followed the existing code standards and didn't mess up the formatting.
I did my best to add documentation to any public classes or methods I added.
I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
I added sufficient Unit Tests to cover my code.

github-actions · 2024-10-01T00:23:22Z

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention	Label
`feature/**`	🎈 Feature
`fix/**`	✨ Fix
`chore/**`	🧹 Chores
`api/**`	🔧 API
`performance/**`	💡 Performance Optimization
`compatibility/**`	🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

github-actions · 2024-10-01T00:26:08Z

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 99cdc01

https://preview-builds.walshy.dev/download/Slimefun/4248/99cdc018

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

src/test/resources/biomes/1.21.x.json

WalshyDev · 2024-10-01T00:46:13Z

This still needs major testing

pom.xml

JustAHuman-xD · 2024-10-01T03:23:20Z

src/test/java/io/github/thebusybiscuit/slimefun4/implementation/items/TestSlimefunItem.java

        ItemStack item = new CustomItemStack(Material.BEACON, "&cItem Test");
        String id = "IS_ITEM_TEST";
-        SlimefunItem sfItem = TestUtilities.mockSlimefunItem(plugin, id, item);
+        SlimefunItem sfItem = TestUtilities.mockSlimefunItem(plugin, id, new CustomItemStack(Material.BEACON, "&cItem Test"));


What's the point of this?

I think its testing that SlimefunItem#register should change the underlying ItemStack in some way, thus sfItem#isItem should return false even if the twoItemStacks were the same when we started.

Boomer-1 · 2024-10-01T04:10:44Z

testing produced multiple errors immediately which stopped any further testing. I've linked them from the contributors channel on discord. https://discord.com/channels/565557184348422174/565570276038017044/1290525215461216266

…istener to use the wrapper on Player#getOpenInventory

sonarcloud · 2024-10-01T07:57:04Z

Quality Gate passed

Issues
30 New issues
0 Accepted issues

Measures
0 Security Hotspots
34.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Stis780 · 2024-10-22T14:37:09Z

testing produced multiple errors immediately which stopped any further testing. I've linked them from the contributors channel on discord. https://discord.com/channels/565557184348422174/565570276038017044/1290525215461216266

Is there 1.21 build available? where? ty mate

Boomer-1 · 2024-10-22T15:30:23Z

testing produced multiple errors immediately which stopped any further testing. I've linked them from the contributors channel on discord. https://discord.com/channels/565557184348422174/565570276038017044/1290525215461216266

Is there 1.21 build available? where? ty mate

no. this is the work being done to get 1.21 up and running.

sruly09 · 2024-10-22T18:54:37Z

when will 1.21 version come out?

Intybyte · 2024-10-22T19:03:21Z

Boomer-1 · 2024-10-22T19:22:36Z

when all the changes that mojang and paper put in place are addressed and fixed. feel free to help

Boomer-1 · 2024-10-22T19:23:54Z

lets try to keep comments not related to the PR on Discord please

Intybyte · 2024-10-27T09:07:26Z

Please stop posting anything here, we already know what we need to fix it just requires time and patience and lots of changes, also you will not recive support for your own fork of the plugin.

JustinDevB · 2024-11-04T16:53:35Z

Do we ever plan on updating this? Or are we just going to let minecraft continue to update and abandon this project

ybw0014 · 2024-11-04T18:40:26Z

@JustinDevB Please do not add noisy comments to this PR, thank you. Questions go on Discord only.

JustinDevB · 2024-11-04T19:07:16Z

@JustinDevB Please do not add noisy comments to this PR, thank you. Questions go on Discord only.

All that happens there is people get warned or muted for asking about the progress. Seems to be a topic nobody is allowed to discuss anywhere.

Lamby777 · 2024-11-04T20:03:56Z

All that happens there is people get warned or muted for asking about the progress. Seems to be a topic nobody is allowed to discuss anywhere.

can confirm, i was banned for no reason (i don't even talk there)

Outfit8TSB · 2024-11-07T09:24:07Z

Please stop posting anything here, we already know what we need to fix it just requires time and patience and lots of changes, also you will not recive support for your own fork of the plugin.

Look, it's not fork(and it's git clone) and it's resolved by #4253. Ok? I marked it as resolved for you.

Co-authored-by: Daniel Walsh <[email protected]>

sonarcloud · 2024-11-09T21:46:55Z

Quality Gate passed

Issues
256 New issues
0 Accepted issues

Measures
0 Security Hotspots
46.4% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarCloud

Boomer-1 · 2024-11-21T04:16:51Z

You're leaving an entire bubble out in the rain, you can keep talking about it, but slimefun will soon die for all the servers that once offered it!

please leave unproductive comments like these out of the PR discussion. since you clearly didn't look at what's going on and seen the progress, you aren't helping anyone.

WalshyDev requested review from a team as code owners October 1, 2024 00:23

WalshyDev force-pushed the walshy/mc-1.21 branch 2 times, most recently from a5de53e to 9f175bf Compare October 1, 2024 00:34

WalshyDev mentioned this pull request Oct 1, 2024

Add multiversion support to ExplosiveTool#createNewBlockExplodeEvent #4245

Closed

7 tasks

WalshyDev commented Oct 1, 2024

View reviewed changes

src/test/resources/biomes/1.21.x.json Outdated Show resolved Hide resolved

WalshyDev added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🤝 Compatibility This Pull Request introduces a compatibility feature. 🎮 Game Update This pull request adds compatibility with a new version of Minecraft. labels Oct 1, 2024

WalshyDev assigned Sefiraat, svr333, Sfiguz7, md5sha256 and Boomer-1 Oct 1, 2024

ybw0014 suggested changes Oct 1, 2024

View reviewed changes

pom.xml Show resolved Hide resolved

WalshyDev force-pushed the walshy/mc-1.21 branch 4 times, most recently from 41f9139 to afaf3aa Compare October 1, 2024 01:03

Update to 1.21

c84e876

WalshyDev force-pushed the walshy/mc-1.21 branch from afaf3aa to c84e876 Compare October 1, 2024 01:17

JustAHuman-xD reviewed Oct 1, 2024

View reviewed changes

md5sha256 added 2 commits October 1, 2024 15:02

Add a temporary InventoryViewWrapper in tests. Refactor TestBackpackL…

b508e45

…istener to use the wrapper on Player#getOpenInventory

Wrap the inventory view after the backpack has been opened

00da02c

This comment has been minimized.

Sign in to view

Outfit8TSB mentioned this pull request Nov 9, 2024

1.21 support #4254

Closed

5 tasks

md5sha256 and others added 2 commits November 9, 2024 19:24

Updates usages of CustomItemStack (#4253)

6f02cae

Co-authored-by: Daniel Walsh <[email protected]>

Remove EnumMap and EnumSet usages (#4258)

47092df

This comment was marked as off-topic.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to 1.21 #4248

Update to 1.21 #4248

WalshyDev commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024 •

edited

Loading

WalshyDev commented Oct 1, 2024

JustAHuman-xD Oct 1, 2024

md5sha256 Oct 1, 2024

Boomer-1 commented Oct 1, 2024

sonarcloud bot commented Oct 1, 2024

Stis780 commented Oct 22, 2024

Boomer-1 commented Oct 22, 2024

sruly09 commented Oct 22, 2024

Intybyte commented Oct 22, 2024

Boomer-1 commented Oct 22, 2024

Boomer-1 commented Oct 22, 2024

This comment has been minimized.

Intybyte commented Oct 27, 2024

JustinDevB commented Nov 4, 2024

ybw0014 commented Nov 4, 2024

JustinDevB commented Nov 4, 2024

Lamby777 commented Nov 4, 2024

Outfit8TSB commented Nov 7, 2024 •

edited

Loading

sonarcloud bot commented Nov 9, 2024

This comment was marked as off-topic.

Boomer-1 commented Nov 21, 2024

Update to 1.21 #4248

Are you sure you want to change the base?

Update to 1.21 #4248

Conversation

WalshyDev commented Oct 1, 2024

Description

Proposed changes

Related Issues (if applicable)

Checklist

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024 • edited Loading

Slimefun preview build

WalshyDev commented Oct 1, 2024

JustAHuman-xD Oct 1, 2024

Choose a reason for hiding this comment

md5sha256 Oct 1, 2024

Choose a reason for hiding this comment

Boomer-1 commented Oct 1, 2024

sonarcloud bot commented Oct 1, 2024

Quality Gate passed

Stis780 commented Oct 22, 2024

Boomer-1 commented Oct 22, 2024

sruly09 commented Oct 22, 2024

Intybyte commented Oct 22, 2024

Boomer-1 commented Oct 22, 2024

Boomer-1 commented Oct 22, 2024

This comment has been minimized.

Intybyte commented Oct 27, 2024

JustinDevB commented Nov 4, 2024

ybw0014 commented Nov 4, 2024

JustinDevB commented Nov 4, 2024

Lamby777 commented Nov 4, 2024

Outfit8TSB commented Nov 7, 2024 • edited Loading

sonarcloud bot commented Nov 9, 2024

Quality Gate passed

This comment was marked as off-topic.

Boomer-1 commented Nov 21, 2024

github-actions bot commented Oct 1, 2024 •

edited

Loading

Outfit8TSB commented Nov 7, 2024 •

edited

Loading