Skip to content

Conversation

DereC4
Copy link

@DereC4 DereC4 commented May 17, 2025

Description

12/22 3:14:56 PM [Error] : [Slimefun] An Exception was caught while ticking the Block Tickers Task for Slimefun vDev - 1157
12/22 3:14:56 PM [Error] java.util.ConcurrentModificationException: null
12/22 3:14:56 PM [Error] at java.util.HashMap$HashIterator.nextNode(HashMap.java:1605) ~[?:?]
12/22 3:14:56 PM [Error] at java.util.HashMap$KeyIterator.next(HashMap.java:1628) ~[?:?]

Being made as we iterate over the value set

Proposed changes

Update tickChunk to iterate over a copy of the set to avoid concurrent modification for protection

Related Issues (if applicable)

#4276

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@DereC4 DereC4 requested a review from a team as a code owner May 17, 2025 18:39
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant