-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
183d960
commit 36f2f2e
Showing
5 changed files
with
203 additions
and
229 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 27 additions & 85 deletions
112
backend/src/build-system/handlers/frontend-code-generate/FixResponseParser.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,103 +1,45 @@ | ||
| import { XMLParser } from 'fast-xml-parser'; | ||
| import { FileOperation, LLMFixResponse } from './FileOperationManager'; | ||
| import { Logger } from '@nestjs/common'; | ||
| import path from 'path'; | ||
| import { FileOperation } from './FileOperationManager'; | ||
|
|
||
| export class FixResponseParser { | ||
| private readonly parser: XMLParser; | ||
| private readonly logger = new Logger('FixResponseParser'); | ||
| private logger = console; | ||
|
|
||
| constructor() { | ||
| this.parser = new XMLParser({ | ||
| ignoreAttributes: false, | ||
| attributeNamePrefix: '', | ||
| textNodeName: 'value', | ||
| allowBooleanAttributes: true, | ||
| alwaysCreateTextNode: true | ||
| }); | ||
| } | ||
| // parse the gpt json input | ||
| parse(json: string, filePath: string): FileOperation[] { | ||
| this.logger.log('Parsing JSON:', json); | ||
|
|
||
| parse(xml: string): LLMFixResponse { | ||
| let parsedData; | ||
| try { | ||
| const parsed = this.parser.parse(xml); | ||
| return this.transformResponse(parsed); | ||
| parsedData = JSON.parse(json); | ||
| } catch (error) { | ||
| this.logger.error('XML parsing failed', error.stack); | ||
| throw new Error('Invalid XML format from LLM'); | ||
| } | ||
| } | ||
|
|
||
| private transformResponse(parsed: any): LLMFixResponse { | ||
| const result: LLMFixResponse = { | ||
| operations: [], | ||
| reasoning: '' | ||
| }; | ||
|
|
||
| // Extract reasoning if available | ||
| result.reasoning = parsed.FIX.REASONING?.value || 'No reasoning provided'; | ||
|
|
||
| // Process operations | ||
| const actions = parsed.FIX.OPERATIONS?.ACTION || []; | ||
| const actionsArray = Array.isArray(actions) ? actions : [actions]; | ||
|
|
||
| for (const action of actionsArray) { | ||
| const operation = this.parseAction(action); | ||
| if (operation) result.operations.push(operation); | ||
| this.logger.error('Error parsing JSON:', error); | ||
| throw new Error('Invalid JSON format'); | ||
| } | ||
|
|
||
| // Handle generated code for WRITE operations | ||
| const generatedCode = parsed.FIX.GENERATE?.value; | ||
| if (generatedCode) { | ||
| this.applyGeneratedCode(result.operations, generatedCode); | ||
| if (!parsedData.fix || !parsedData.fix.operations) { | ||
| throw new Error("Invalid JSON structure: Missing 'fix.operations'"); | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| private parseAction(action: any): FileOperation | null { | ||
| try { | ||
| switch (action.type.toUpperCase()) { | ||
| case 'WRITE': | ||
| const operations: FileOperation[] = parsedData.fix.operations | ||
| .map((op: any) => { | ||
| if (op.type === 'WRITE') { | ||
| return { | ||
| action: 'write', | ||
| path: this.sanitizePath(action.path), | ||
| originalPath: '', // Not used for write | ||
| content: '' // Temporarily empty | ||
| originalPath: filePath, | ||
| code: parsedData.fix.generate?.trim(), | ||
| }; | ||
| case 'RENAME': | ||
| } else if (op.type === 'RENAME') { | ||
| return { | ||
| action: 'rename', | ||
| path: this.sanitizePath(action.path), | ||
| originalPath: this.sanitizePath(action.ORIGINAL_PATH.value) | ||
| originalPath: op.original_path, | ||
| renamePath: op.path, | ||
| code: parsedData.fix.generate?.trim(), | ||
| }; | ||
| default: | ||
| this.logger.warn(`Unknown action type: ${action.type}`); | ||
| return null; | ||
| } | ||
| } catch (error) { | ||
| this.logger.warn(`Invalid action format: ${JSON.stringify(action)}`); | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| private applyGeneratedCode(operations: FileOperation[], code: string): void { | ||
| const writeOperations = operations.filter(op => op.action === 'write'); | ||
| if (writeOperations.length > 0) { | ||
| // Apply generated code to the first WRITE operation | ||
| writeOperations[0].content = code; | ||
| } | ||
| } | ||
|
|
||
| private sanitizePath(rawPath: string): string { | ||
| const sanitized = path.normalize(rawPath) | ||
| .replace(/(\.\.\/|\.\.\\)/g, '') // Prevent path traversal | ||
| .replace(/^\/+/, '') // Remove leading slashes | ||
| .trim(); | ||
|
|
||
| if (!sanitized) { | ||
| throw new Error(`Invalid path after sanitization: ${rawPath}`); | ||
| } | ||
| } | ||
| return null; | ||
| }) | ||
| .filter(Boolean); | ||
|
|
||
| return sanitized; | ||
| this.logger.log('Extracted operations:', operations); | ||
| return operations; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.