Matter Electrical Sensor: Support Power Topology Cluster #2444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
Test Results 71 files ± 0 460 suites +1 0s ⏱️ ±0s Results for commit c818081. ± Comparison against base commit fb3f845. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against c818081 |
hcarter-775
force-pushed
the
power-topology-support
branch
2 times, most recently
from
3105c81 to
428476c
Compare
hcarter-775
force-pushed
the
power-topology-support
branch
from
aee0647 to
c818081
Compare
|
Duplicate profile check: Passed - no duplicate profiles detected. |
Comment on lines
+30
to
+31
| clusters.ElectricalEnergyMeasurement.ID = 0x0091 | ||
| clusters.ElectricalPowerMeasurement.ID = 0x0090 |
There was a problem hiding this comment.
Aren't these ID's already present in the embedded clusters? Or is it just that the IDs are the only thing needed in this module?
There was a problem hiding this comment.
yeah I could have just included the whole thing there, but since only the IDs are being used in this file I just specified the IDs.
| function AttributeHandlers.active_power_handler(driver, device, ib, response) | ||
| if ib.data.value then | ||
| local watt_value = ib.data.value / fields.CONVERSION_CONST_MILLIWATT_TO_WATT | ||
| if ib.endpoint_id ~= 0 then |
There was a problem hiding this comment.
Is this logic not needed anymore? I'm a bit confused
There was a problem hiding this comment.
see this PR: #2436
specifically here: #2436 (comment)
hcarter-775
force-pushed
the
update-metadata-switch
branch
from
fb3f845 to
73aa8dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Multi-switch plugs that support Electrical Sensor on multiple endpoints are not currently handled correctly in the driver, as the electrical handling is silently dropped when creating a profile for all child devices. This PR aims to fix that by adding handling of the PowerTopology cluster, a required cluster for the Electrical Sensor device type.
This cluster primarily indicates how Electrical Sensors are organized on the device through its feature map, and this PR handles 2 of the permutations, namely SET and NODE. For now, all other permutations (primarily TREE) will be silently dropped if it is supported, though we know of no real devices using this topology.
In the spec, a NODE topology indicates that there is only one source of electrical readings for the entire device, the "node". A SET topology indicates that the electrical sensor supports readings for some subset of the devices, and therefore there are likely >1 of these sensors, each with a SET topology and each supporting readings of different endpoints. These endpoints are specified through the AvailableEndpoints attribute, which we read on an initial join.
Summary of Completed Tests