Matter Switch: Include Ikea subdriver support for knob capability #2678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcarter-775
requested review from
Kwang-Hui,
ctowns,
greens,
nickolas-deboom and
tpmanley
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 480 suites 0s ⏱️ Results for commit 05b47bd. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 05b47bd |
nickolas-deboom
approved these changes
Dec 30, 2025
Comment on lines
+218
to
+230
| elseif type(map_info) == "table" then | ||
| if type(map_info.endpoint_id) == "number" then | ||
| map_info = {map_info} | ||
| end | ||
| for _, ep_map_info in ipairs(map_info) do | ||
| if type(ep_map_info) == "number" and ep_map_info == ep_info.endpoint_id then | ||
| return component | ||
| elseif type(ep_map_info) == "table" and ep_map_info.endpoint_id == ep_info.endpoint_id | ||
| and (not ep_map_info.cluster_id or (ep_map_info.cluster_id == ep_info.cluster_id | ||
| and (not ep_map_info.attribute_ids or utils.tbl_contains(ep_map_info.attribute_ids, ep_info.attribute_id)))) then | ||
| return component | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
The logic here is a little hard to follow. I'm not quite understanding why this change is needed to support multiple endpoints mapping to the same component? Wouldn't the table layout of map_info be the same? does the old code not actually work for this case?
nickolas-deboom
approved these changes
Jan 8, 2026
Contributor
nickolas-deboom
left a comment
nickolas-deboom
left a comment
There was a problem hiding this comment.
I left a comment about some confusion I had, but the rest all looks good from my perspective. As long as this has been testing on device and everything's working, I don't see any reason to hold up any of these changes. Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update scroll profile to support knob capability. Include unique event handlers for knob and initial press.
This breaks apart the work found in #2669 so that the knob capability support can be reviewed as an isolated unit.
Summary of Completed Tests
Unit test included. Tested on-device.