Matter Switch: Add new RGBW profile with a fixed W #2689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcarter-775
requested review from
cjswedes,
ctowns,
gharveymn,
greens and
nickolas-deboom
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
hcarter-775
commented
Jan 7, 2026
Comment on lines
+203
to
+206
| elseif switch_utils.check_switch_category_vendor_overrides(device) then | ||
| -- check whether the overwrite should be over "plug" or "light" based on the current profile | ||
| local overwrite_category = string.find(updated_profile, "plug") and "plug" or "light" | ||
| updated_profile = string.gsub(updated_profile, overwrite_category, "switch") |
Contributor
Author
There was a problem hiding this comment.
This change is technically unrelated. When looking this over, I didn't think it was generic to assume all devices using a "Switch" category override have a plug device type. That does make the most since I think, but should not be a prerequisite in this logic.
Test Results 71 files 480 suites 0s ⏱️ Results for commit de15c71. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against de15c71 |
hcarter-775
force-pushed
the
add-fixed-W-RGBW-profile
branch
from
d954c80 to
de15c71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add new profile,
light-color-level-noTemp, to handle devices supporting color but no temperature. Adds new default logic, gating on the ColorTemeperature Feature, to define this.To make this work, I had to work around the current deprecated profiles used by fingerprints, so that generic color lights could be re-profiled. To do this, I did 2 things:
2200K-6500Kfingerprints the generic counterpart. Since this is the default in the generic profile, this changes nothing on the user end.Summary of Completed Tests
Unit tests updated to ensure proper updates, unit test added for new functionality.