Skip to content

Matter Switch: Update switchLevel handler from floor to round #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hcarter-775 merged 1 commit into from
Jan 9, 2026
Merged

Matter Switch: Update switchLevel handler from floor to round #2690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/SmartThings/matter-switch/src/switch_handlers/capability_handlers.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function CapabilityHandlers.handle_switch_set_level(driver, device, cmd)
device:register_native_capability_cmd_handler(cmd.capability, cmd.command)
end
local endpoint_id = device:component_to_endpoint(cmd.component)
local level = math.floor(cmd.args.level/100.0 * 254)
local level = st_utils.round(cmd.args.level/100.0 * 254)
device:send(clusters.LevelControl.server.commands.MoveToLevelWithOnOff(device, endpoint_id, level, cmd.args.rate, 0, 0))
end

Expand Down
3 changes: 2 additions & 1 deletion drivers/SmartThings/matter-switch/src/test/test_electrical_sensor_set.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ local clusters = require "st.matter.clusters"
local t_utils = require "integration_test.utils"
local uint32 = require "st.matter.data_types.Uint32"
local version = require "version"
local st_utils = require "st.utils"

if version.api < 11 then
clusters.ElectricalEnergyMeasurement = require "embedded_clusters.ElectricalEnergyMeasurement"
Expand Down Expand Up @@ -678,7 +679,7 @@ test.register_message_test(
direction = "send",
message = {
mock_device.id,
clusters.LevelControl.server.commands.MoveToLevelWithOnOff(mock_device, 2, math.floor(20/100.0 * 254), 20, 0 ,0)
clusters.LevelControl.server.commands.MoveToLevelWithOnOff(mock_device, 2, st_utils.round(20/100.0 * 254), 20, 0 ,0)
}
},
{
Expand Down
3 changes: 2 additions & 1 deletion drivers/SmartThings/matter-switch/src/test/test_electrical_sensor_tree.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ local clusters = require "st.matter.clusters"
local t_utils = require "integration_test.utils"
local uint32 = require "st.matter.data_types.Uint32"
local version = require "version"
local st_utils = require "st.utils"

if version.api < 11 then
clusters.ElectricalEnergyMeasurement = require "embedded_clusters.ElectricalEnergyMeasurement"
Expand Down Expand Up @@ -334,7 +335,7 @@ test.register_message_test(
direction = "send",
message = {
mock_device.id,
clusters.LevelControl.server.commands.MoveToLevelWithOnOff(mock_device, 2, math.floor(20/100.0 * 254), 20, 0 ,0)
clusters.LevelControl.server.commands.MoveToLevelWithOnOff(mock_device, 2, st_utils.round(20/100.0 * 254), 20, 0 ,0)
}
},
{
Expand Down
3 changes: 2 additions & 1 deletion drivers/SmartThings/matter-switch/src/test/test_light_illuminance_motion.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
local test = require "integration_test"
local capabilities = require "st.capabilities"
local t_utils = require "integration_test.utils"
local st_utils = require "st.utils"

local clusters = require "st.matter.clusters"
local TRANSITION_TIME = 0
Expand Down Expand Up @@ -221,7 +222,7 @@ test.register_message_test(
direction = "send",
message = {
mock_device.id,
clusters.LevelControl.server.commands.MoveToLevelWithOnOff(mock_device, 1, math.floor(20/100.0 * 254), 20, 0 ,0)
clusters.LevelControl.server.commands.MoveToLevelWithOnOff(mock_device, 1, st_utils.round(20/100.0 * 254), 20, 0 ,0)
}
},
{
Expand Down
5 changes: 3 additions & 2 deletions drivers/SmartThings/matter-switch/src/test/test_matter_switch.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
local test = require "integration_test"
local capabilities = require "st.capabilities"
local t_utils = require "integration_test.utils"
local st_utils = require "st.utils"

local clusters = require "st.matter.clusters"
local TRANSITION_TIME = 0
Expand Down Expand Up @@ -343,7 +344,7 @@ test.register_message_test(
direction = "send",
message = {
mock_device.id,
clusters.LevelControl.server.commands.MoveToLevelWithOnOff(mock_device, 1, math.floor(20/100.0 * 254), 20, 0 ,0)
clusters.LevelControl.server.commands.MoveToLevelWithOnOff(mock_device, 1, st_utils.round(20/100.0 * 254), 20, 0 ,0)
}
},
{
Expand Down Expand Up @@ -414,7 +415,7 @@ test.register_message_test(
{
channel = "capability",
direction = "send",
message = mock_device:generate_test_message("main", capabilities.switchLevel.level(math.floor((50 / 254.0 * 100) + 0.5)))
message = mock_device:generate_test_message("main", capabilities.switchLevel.level(st_utils.round((50 / 254.0 * 100) + 0.5)))
},
{
channel = "devices",
Expand Down
Loading