Fixes after testing the quality module implementation

Smile-SA · Oct 19, 2022 · e2311b1 · e2311b1
1 parent f6722de
commit e2311b1
Show file tree

Hide file tree

Showing 10 changed files with 27 additions and 54 deletions.
diff --git a/.phpqa.yml b/.phpqa.yml
diff --git a/.travis.yml b/.travis.yml
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.3.6] - 2022-10-19
+[1.3.6]: https://github.com/Smile-SA/magento2-module-custom-entity-product-link/compare/1.3.5...1.3.6
+
+- Add Smile Lab Quality Suite
+- Analyse code style with phpcs / phpmd / phpstan command
+- Add db_schema.xml instead InstallSchema
+
 ## [1.3.5] - 2022-09-20
 [1.3.5]: https://github.com/Smile-SA/magento2-module-custom-entity-product-link/compare/1.3.4...1.3.5
 

diff --git a/Helper/Product.php b/Helper/Product.php
@@ -46,10 +46,10 @@ public function __construct(
     public function getCustomEntities(ProductInterface $product, string $attributeCode): array
     {
         $result = [];
-        // @phpstan-ignore-next-line
         $customEntities = $product->getExtensionAttributes()->getCustomEntities();
         if ($customEntities) {
             foreach ($customEntities as $customEntity) {
+                // @phpstan-ignore-next-line
                 if ($customEntity->getProductAttributeCode() !== $attributeCode || !$customEntity->getIsActive()) {
                     continue;
                 }

diff --git a/Model/ResourceModel/CustomEntityProductLinkManagement.php b/Model/ResourceModel/CustomEntityProductLinkManagement.php
@@ -9,7 +9,7 @@
 /**
  * Custom entity product link management resource model.
  */
-abstract class CustomEntityProductLinkManagement extends AbstractDb
+class CustomEntityProductLinkManagement extends AbstractDb
 {
     public const RELATION_TABLE_NAME = 'catalog_product_custom_entity_link';
 
@@ -77,4 +77,13 @@ public function saveLinks($productId, $attributeId, array $entityIds): CustomEnt
 
         return $this;
     }
+
+    /**
+     * @inheritDoc
+     */
+    // @codingStandardsIgnoreLine
+    protected function _construct()
+    {
+        // TODO: Implement _construct() method.
+    }
 }
diff --git a/composer.json b/composer.json
@@ -11,13 +11,11 @@
     ],
     "require": {
         "php": "^7.4 || ^8.1",
-        "smile/module-custom-entity": "~1.3.0",
+        "smile/module-custom-entity": "^1.3",
         "smile/elasticsuite": "^2.8.0"
     },
     "require-dev": {
-        "smile/magento2-smilelab-quality-suite": "^1.0.5",
-        "edgedesign/phpqa": "^1.18",
-        "jakub-onderka/php-parallel-lint": "^0.9.2"
+        "smile/magento2-smilelab-quality-suite": "^3.0"
     },
     "license": "OSL-3.0",
     "authors": [

diff --git a/phpcs.xml b/phpcs.xml
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -16,5 +16,6 @@
 
     <rule ref="SmileLab"/>
 
+    <file>.</file>
     <exclude-pattern>vendor/*</exclude-pattern>
 </ruleset>
diff --git a/phpmd.xml b/phpmd.xml
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -2,8 +2,14 @@ parameters:
     level: 6
     phpVersion: 70400
     checkMissingIterableValueType: false
+    paths:
+        - .
     excludePaths:
         - 'vendor/*'
+    ignoreErrors:
+        -
+            message: '#Constant BP not found#'
+            path: registration.php
 
 includes:
     - %currentWorkingDirectory%/vendor/smile/magento2-smilelab-phpstan/extension.neon