-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/egl context priority #1133
Feature/egl context priority #1133
Conversation
Can we make the second commit add the priority as constructor arguments for the |
Yes, though we only have a default impl and |
I guess we have two options:
I am happy with both options. |
I believe vulkan has an extension similar to this, so we can elect to specify a priority from the multigpu code, although it's an optional extension: https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_global_priority.html |
1cd5b33
to
4f5f9a0
Compare
I opted for the first option, which really seems more sensible as |
no_coverage has been replaced with coverage(off) which breaks the CI build
4f5f9a0
to
e5e1d0c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1133 +/- ##
==========================================
- Coverage 22.94% 22.88% -0.07%
==========================================
Files 143 143
Lines 22972 23050 +78
==========================================
+ Hits 5272 5275 +3
- Misses 17700 17775 +75
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This PR adds support for egl context priority using the EGL_IMG_context_priority egl extension.
It also changes the multigpu code to request a high priority context by default.